Re: [PATCH] MODSIGN: Warn when module signature checking fails

Rusty Russell
2013-01-21T01:53:54Z

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi Rusty,
>
> On Mon, 21 Jan 2013 10:06:11 +1030 Rusty Russell <rusty@rustcorp.com.au> wrote:
>>
>> #ifdef CONFIG_MODULE_SIG
>> mod->sig_ok = info->sig_ok;
>> - if (!mod->sig_ok)
>> + if (!mod->sig_ok) {
>> + printk_once(KERN_NOTICE
>> + "%s: module verification failed: signature and/or"
>> + " required key missing - tainting kernel\n");
>
> Did you forget to add "mod->name"?

Indeed (turns back on CONFIG_MODULE_SIG).

Thanks,
Rusty.