From: Michal Marek <mmarek@suse.cz>
To: Roland Eggner <edvx1@systemanalysen.net>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>,
Dmitry Voytik <dvv.kernel@gmail.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v2 1/2] nconf: add keybindings for vi-style menu navigation, rewrite help texts
Date: Wed, 16 Jan 2013 13:48:07 +0100 [thread overview]
Message-ID: <50F6A187.7010101@suse.cz> (raw)
In-Reply-To: <20130115162632.GB5513@mobil.systemanalysen.net>
On 15.1.2013 17:26, Roland Eggner wrote:
>> From: Roland Eggner <edvx1@systemanalysen.net>
>
> • Implemented vi-style navigation <k> <j> <l> <h>, based on initial work by
> Dmitry Voytik. Using <?> <H> instead of <?> <h> for help related to current
> menu entry avoids conflict.
It conflicts with previous behavior that people got used to, though.
Also, please split the patch at least into one part adding the new key
binding and a second part rewriting the help texts.
Michal
next prev parent reply other threads:[~2013-01-16 12:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 19:12 [PATCH] nconf: add j, k and l keys for menu navigation Dmitry Voytik
2012-12-21 20:23 ` Stephen Boyd
2012-12-22 5:27 ` Dmitry Voytik
2012-12-28 18:51 ` Dmitry Voytik
2012-12-28 19:40 ` [PATCH] nconf: add vi-style command keys for the " Dmitry Voytik
2012-12-29 22:33 ` [PATCH 2/2] nconf: function keys line, change background color for better readability Roland Eggner
2013-01-14 22:20 ` Yann E. MORIN
2013-01-14 22:26 ` Yann E. MORIN
2012-12-29 22:34 ` [PATCH 1/2] nconf: add keybindings for vi-style menu navigation, rewrite help texts Roland Eggner
2013-01-08 22:04 ` Yann E. MORIN
2013-01-14 18:24 ` Yann E. MORIN
2013-01-15 16:10 ` Roland Eggner
2013-01-15 16:26 ` [PATCH v2 " Roland Eggner
2013-01-15 16:36 ` [PATCH v2stable " Roland Eggner
2013-01-15 17:39 ` Yann E. MORIN
2013-01-15 22:27 ` [PATCH v2 " Yann E. MORIN
2013-01-16 20:19 ` Roland Eggner
2013-01-16 12:48 ` Michal Marek [this message]
2013-01-08 21:57 ` [PATCH] nconf: add vi-style command keys for the menu navigation Yann E. MORIN
2013-01-14 22:10 ` Yann E. MORIN
2013-01-15 17:12 ` Roland Eggner
2013-01-15 17:38 ` Yann E. MORIN
2013-01-15 17:55 ` Roland Eggner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F6A187.7010101@suse.cz \
--to=mmarek@suse.cz \
--cc=dvv.kernel@gmail.com \
--cc=edvx1@systemanalysen.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox