Re: [PATCH 00/10] TTY: switch flipping functions to tty_port

[Jiri Slaby <jslaby@suse.cz>]

On 01/16/2013 04:44 PM, Steven Rostedt wrote:
> On Wed, 2013-01-16 at 14:37 +0100, Jiri Slaby wrote:
>> Steven, do you have any plans with the driver? What is its planned destiny?
> 
> Well, I'm currently using the device in my main machine. As it is my
> main box, I don't update the kernel as often.
> 
> Let me know what I need to do to fix it in the current kernel.

Every port in the system has to have its struct tty_port counterpart.

/me looked into the code

OMG. It contains a true copy of serial_core!

In the beginning (to remove the BROKEN flag), what it needs is struct
tty_port to be added to struct sb_uart_info. It obviously needs
tty_port_init + tty_port_destroy at appropriate places. Then it needs
tty_register_device to be switched to tty_port_register_device.

Finally, having the tty_port, all tty flipping functions take the
tty_port, not tty_struct (the build errors reported). This is easy while
you have a tty_port.

In the long term, it needs to get rid of the all the pseudo-uart* stuff
(the copy of serial_core) and use only tty layer+tty_port helpers.

thanks,
-- 
js
suse labs