From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932209Ab3AQKcy (ORCPT ); Thu, 17 Jan 2013 05:32:54 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:54719 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757731Ab3AQKcv (ORCPT ); Thu, 17 Jan 2013 05:32:51 -0500 Message-ID: <50F7D346.3040101@ti.com> Date: Thu, 17 Jan 2013 12:32:38 +0200 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Sergei Shtylyov CC: , , , , , , , Subject: Re: [PATCH v6 03/22] mfd: omap-usb-tll: Use devm_kzalloc/ioremap and clean up error path References: <1358347433-329-1-git-send-email-rogerq@ti.com> <1358347433-329-4-git-send-email-rogerq@ti.com> <50F70164.3080105@mvista.com> <50F7C074.5070803@ti.com> In-Reply-To: <50F7C074.5070803@ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/17/2013 11:12 AM, Roger Quadros wrote: > On 01/16/2013 09:37 PM, Sergei Shtylyov wrote: >> Hello. >> >> On 01/16/2013 05:43 PM, Roger Quadros wrote: >> >>> Use devm_ variants of kzalloc() and ioremap(). Simplify the error path. >> >>> Signed-off-by: Roger Quadros >>> --- >>> drivers/mfd/omap-usb-tll.c | 36 +++++++++++------------------------- >>> 1 files changed, 11 insertions(+), 25 deletions(-) >> >>> diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c >>> index 9658e18..53ed10b 100644 >>> --- a/drivers/mfd/omap-usb-tll.c >>> +++ b/drivers/mfd/omap-usb-tll.c >> [...] >>> - base = ioremap(res->start, resource_size(res)); >>> + base = devm_request_and_ioremap(dev, res); >>> if (!base) { >>> - dev_err(dev, "TLL ioremap failed\n"); >>> ret = -ENOMEM; >> >> -EADDRNOTAVAIL as the comment to devm_request_and_ioremap() suggests. >> > > I changed it deliberately to ENOMEM, as I could not find EADDRNOTAVAIL > defined in all architectures. > > ENOMEM shouldn't harm. > Correcting myself, It is defined here include/uapi/asm-generic/errno.h:#define EADDRNOTAVAIL 99 /* Cannot assign requested address */ So i'll update both patches. -- cheers, -roger