From: Richard Mortimer <richm@oldelvet.org.uk>
To: Cong Ding <dinggnu@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
"David S. Miller" <davem@davemloft.net>,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sparc: kernel/sbus.c: fix memory leakage
Date: Thu, 17 Jan 2013 10:41:59 +0000 [thread overview]
Message-ID: <50F7D577.8010506@oldelvet.org.uk> (raw)
In-Reply-To: <20130116220153.GD18593@gmail.com>
On 16/01/2013 22:01, Cong Ding wrote:
> the variable iommu and strbuf are not freed if it goes to error.
>
> Signed-off-by: Cong Ding <dinggnu@gmail.com>
> ---
> arch/sparc/kernel/sbus.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/sparc/kernel/sbus.c b/arch/sparc/kernel/sbus.c
> index 1271b3a..78aa26b 100644
> --- a/arch/sparc/kernel/sbus.c
> +++ b/arch/sparc/kernel/sbus.c
> @@ -656,6 +656,8 @@ static void __init sbus_iommu_init(struct platform_device *op)
> return;
>
> fatal_memory_error:
> + kfree(strbuf);
strbuf will be uninitialized if the iommu allocation fails. I don't have
a particular preference for how to fix this but tend to dislike initial
assignment with NULL because it hides other control flow issues.
Regards
Richard
> + kfree(iommu);
> prom_printf("sbus_iommu_init: Fatal memory allocation error.\n");
> }
>
>
next prev parent reply other threads:[~2013-01-17 10:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 21:36 [PATCH] sparc: kernel/sbus.c: fix memory leakage Cong Ding
2013-01-16 21:13 ` Sam Ravnborg
2013-01-16 21:17 ` Cong Ding
2013-01-16 22:00 ` Sam Ravnborg
2013-01-16 22:01 ` [PATCH v2] " Cong Ding
2013-01-17 10:41 ` Richard Mortimer [this message]
2013-01-17 11:56 ` Cong Ding
2013-01-17 12:30 ` Richard Mortimer
2013-01-17 13:16 ` Cong Ding
2013-01-17 13:28 ` [PATCH v3] " Cong Ding
2013-01-21 22:20 ` Richard Mortimer
2013-01-21 22:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F7D577.8010506@oldelvet.org.uk \
--to=richm@oldelvet.org.uk \
--cc=davem@davemloft.net \
--cc=dinggnu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox