public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Holler <holler@ahsoftware.de>
To: Axel Lin <axel.lin@ingics.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Alessandro Zummo <a.zummo@towertech.it>,
	rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: hid-sensor-time: Add missing spin_lock_init
Date: Thu, 17 Jan 2013 13:47:51 +0100	[thread overview]
Message-ID: <50F7F2F7.9010900@ahsoftware.de> (raw)
In-Reply-To: <1358387389.17958.1.camel@phoenix>

Am 17.01.2013 02:49, schrieb Axel Lin:

Thanks, yes, I missed it the initialization of the spinlock.

Below is my ack.

Regards,

Alexander

> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Acked-by: Alexander Holler <holler@ahsoftware.de>

> ---
>   drivers/rtc/rtc-hid-sensor-time.c |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rtc/rtc-hid-sensor-time.c b/drivers/rtc/rtc-hid-sensor-time.c
> index 0438c9e..31c5728 100644
> --- a/drivers/rtc/rtc-hid-sensor-time.c
> +++ b/drivers/rtc/rtc-hid-sensor-time.c
> @@ -225,6 +225,7 @@ static int hid_time_probe(struct platform_device *pdev)
>
>   	platform_set_drvdata(pdev, time_state);
>
> +	spin_lock_init(&time_state->lock_last_time);
>   	init_completion(&time_state->comp_last_time);
>   	time_state->common_attributes.hsdev = hsdev;
>   	time_state->common_attributes.pdev = pdev;
>


  parent reply	other threads:[~2013-01-17 12:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-17  1:49 [PATCH] rtc: hid-sensor-time: Add missing spin_lock_init Axel Lin
2013-01-17  1:58 ` Thiago Farina
2013-01-17 12:58   ` Alexander Holler
2013-01-17 12:47 ` Alexander Holler [this message]
2013-01-20 12:02   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F7F2F7.9010900@ahsoftware.de \
    --to=holler@ahsoftware.de \
    --cc=a.zummo@towertech.it \
    --cc=axel.lin@ingics.com \
    --cc=jic23@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox