Re: [PATCH] usb: musb: ux500: use clk_prepare_enable and clk_disable_unprepare

Linus Walleij
2013-01-17T10:46:32Z

On Thu, Jan 10, 2013 at 2:38 PM, Fabio Baltieri
<fabio.baltieri@linaro.org> wrote:
> On Thu, Jan 10, 2013 at 12:23:32PM +0100, Linus Walleij wrote:
>> On Mon, Jan 7, 2013 at 5:47 PM, Fabio Baltieri
>> <fabio.baltieri@linaro.org> wrote:
>>
>> > This patch converts the module to use clk_prepare_enable and
>> > clk_disable_unprepare variants as required by common clock framework.
>> >
>> > Without this the system crash during probe function.
>> >
>> > Signed-off-by: Fabio Baltieri <fabio.baltieri@linaro.org>
>>
>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Thanks for the ACK. This bug was here unnoticed since 3.6 merge window,

Then it should have Cc: stable@kernel.org..

> do you think it may make sense to add this driver to u8500_defconfig? I
> can send a patch if you say so...

Yes, can you make a patch updating the defconfig and also enabling
a few other things like charging maybe? Sync with Lee.

Yours,
Linus Walleij