From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756955Ab3AQPpy (ORCPT <rfc822;w@1wt.eu>);
	Thu, 17 Jan 2013 10:45:54 -0500
Received: from mail-la0-f48.google.com ([209.85.215.48]:50837 "EHLO
	mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756737Ab3AQPpw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 17 Jan 2013 10:45:52 -0500
Message-ID: <50F82A4E.3080304@mvista.com>
Date: Thu, 17 Jan 2013 19:43:58 +0300
From: Sergei Shtylyov <sshtylyov@mvista.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130107 Thunderbird/17.0.2
MIME-Version: 1.0
To: kishon <kishon@ti.com>
CC: grant.likely@secretlab.ca, b-cousson@ti.com, rob.herring@calxeda.com,
        rob@landley.net, linux@arm.linux.org.uk, arnd@arndb.de, balbi@ti.com,
        tony@atomide.com, devicetree-discuss@lists.ozlabs.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
        linux-omap@vger.kernel.org
Subject: Re: [RFC PATCH 2/7] ARM: OMAP: devices: create device for usb part
 of control module
References: <1358239378-10030-1-git-send-email-kishon@ti.com> <1358239378-10030-3-git-send-email-kishon@ti.com> <50F5514A.2040207@mvista.com> <50F56703.1060202@ti.com>
In-Reply-To: <50F56703.1060202@ti.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello.

On 01/15/2013 05:26 PM, kishon wrote:

>> On 15-01-2013 12:42, Kishon Vijay Abraham I wrote:

>>> A seperate driver has been added to handle the usb part of control
>>> module. A device for the above driver is created here, using the register
>>> address information to be used by the driver for powering on the PHY and
>>> for writing to the mailbox.

>>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>>> ---
>>>   arch/arm/mach-omap2/devices.c |   50
>>> +++++++++++++++++++++++++++++++++++++++++
>>>   1 file changed, 50 insertions(+)

>>> diff --git a/arch/arm/mach-omap2/devices.c
>>> b/arch/arm/mach-omap2/devices.c
>>> index 5e304d0..a761faf4 100644
>>> --- a/arch/arm/mach-omap2/devices.c
>>> +++ b/arch/arm/mach-omap2/devices.c
>> [...]
>>> @@ -254,6 +255,54 @@ static inline void omap_init_camera(void)
>>>   #endif
>>>   }
>>>
>>> +#if (defined(CONFIG_OMAP_CONTROL_USB) || \
>>> +                defined(CONFIG_OMAP_CONTROL_USB_MODULE))

>>     () around || not needed, and you're indenting the second line too much.

>>> +static inline void __init omap_init_control_usb(void)
>>> +{
>>> +    int ret = 0;

>>     Initializer not needed.

>>> +
>>> +    if (cpu_is_omap44xx()) {
>>> +        ret = platform_device_register(&omap4_control_usb);
>>> +        if (ret)
>>> +            pr_err("Error registering omap_control_usb device: %d\n"
>>> +                , ret);

>>     Please leave the comma on the previous line.

> Sure. I'll fix it.

   Actually, you can use #if IS_ENABLED(CONFIG_OMAP_CONTROL_USB) now instead of
your above constuct.

WBR, Sergei