From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754872Ab3AQRfR (ORCPT ); Thu, 17 Jan 2013 12:35:17 -0500 Received: from hqemgate04.nvidia.com ([216.228.121.35]:19127 "EHLO hqemgate04.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752776Ab3AQRfN (ORCPT ); Thu, 17 Jan 2013 12:35:13 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Thu, 17 Jan 2013 09:34:20 -0800 Message-ID: <50F83631.9080208@nvidia.com> Date: Thu, 17 Jan 2013 23:04:41 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: Stephen Warren CC: Thierry Reding , Alan Cox , Greg Kroah-Hartman , Jiri Slaby , Stephen Warren , "linux-serial@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] serial: tegra: Switch to using struct tty_port References: <1358429505-31746-1-git-send-email-thierry.reding@avionic-design.de> <50F82FE7.9090403@wwwdotorg.org> In-Reply-To: <50F82FE7.9090403@wwwdotorg.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 17 January 2013 10:37 PM, Stephen Warren wrote: > On 01/17/2013 06:31 AM, Thierry Reding wrote: >> Many of the tty functions were converted to use a struct tty_port >> instead of a struct tty_struct. Update the Tegra driver accordingly to >> avoid build breakage. > I tested that this does indeed fix the build warnings. I didn't test the > resultant driver. > The api prototype changes and driver development went in parallel and hence the driver uses the older api. Both got merged on similar time and so out of sync. I think this change is proper. I have not tested this change but reviewing code, it looks good to me. Acked-By: Laxman Dewangan