public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: Roger Quadros <rogerq@ti.com>
Cc: <sameo@linux.intel.com>, <balbi@ti.com>, <tony@atomide.com>,
	<kishon@ti.com>, <sshtylyov@mvista.com>, <bjorn@mork.no>,
	<linux@arm.linux.org.uk>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH v8 01/22] USB: ehci-omap: Don't free gpios that we didn't request
Date: Fri, 18 Jan 2013 14:36:27 +0200	[thread overview]
Message-ID: <50F941CB.1080808@ti.com> (raw)
In-Reply-To: <1358511445-26656-2-git-send-email-rogerq@ti.com>

On 01/18/2013 02:17 PM, Roger Quadros wrote:
> This driver does not request any gpios so don't free them.
> Fixes L3 bus error on multiple modprobe/rmmod of ehci_hcd
> with ehci-omap in use.
> 
> Without this patch, EHCI will break on repeated insmod/rmmod
> of ehci_hcd for all OMAP2+ platforms that use EHCI and
> set 'phy_reset = true' in usbhs_omap_board_data.
> i.e.
> 
> board-3430sdp.c:	.phy_reset  = true,
> board-3630sdp.c:	.phy_reset  = true,
> board-am3517crane.c:	.phy_reset  = true,
> board-am3517evm.c:	.phy_reset  = true,
> board-cm-t3517.c:	.phy_reset  = true,
> board-cm-t35.c:	.phy_reset  = true,
> board-devkit8000.c:	.phy_reset  = true,
> board-igep0020.c:	.phy_reset = true,
> board-igep0020.c:	.phy_reset = true,
> board-omap3beagle.c:	.phy_reset  = true,
> board-omap3evm.c:	.phy_reset  = true,
> board-omap3pandora.c:	.phy_reset  = true,
> board-omap3stalker.c:	.phy_reset = true,
> board-omap3touchbook.c:	.phy_reset  = true,
> board-omap4panda.c:	.phy_reset  = false,
> board-overo.c:	.phy_reset  = true,
> board-zoom.c:	.phy_reset		= true,
> 
> CC: Alan Stern <stern@rowland.harvard.edu>
> Cc: stable@kernel.org

I messed up with the stable list id, so will resend just this one
and update the git repo.

> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> Reviewed-by: Felipe Balbi <balbi@ti.com>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>

cheers,
-roger


  reply	other threads:[~2013-01-18 12:36 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-18 12:17 [PATCH v8 00/22] OMAP USB Host cleanup Roger Quadros
2013-01-18 12:17 ` [PATCH v8 01/22] USB: ehci-omap: Don't free gpios that we didn't request Roger Quadros
2013-01-18 12:36   ` Roger Quadros [this message]
2013-01-18 12:17 ` [PATCH v8 02/22] mfd: omap-usb-host: Consolidate OMAP USB-HS platform data Roger Quadros
2013-01-18 12:17 ` [PATCH v8 03/22] mfd: omap-usb-tll: Fix channel count detection Roger Quadros
2013-01-18 12:17 ` [PATCH v8 04/22] mfd: omap-usb-tll: Use devm_kzalloc/ioremap and clean up error path Roger Quadros
2013-01-18 12:17 ` [PATCH v8 05/22] mfd: omap-usb-tll: Clean up clock handling Roger Quadros
2013-01-18 14:59   ` Russell King - ARM Linux
2013-01-18 15:04     ` Roger Quadros
2013-01-21 11:04     ` [PATCH v9 " Roger Quadros
2013-01-21 16:01       ` Russell King - ARM Linux
2013-01-18 12:17 ` [PATCH v8 06/22] mfd: omap-usb-tll: introduce and use mode_needs_tll() Roger Quadros
2013-01-18 15:02   ` Russell King - ARM Linux
2013-01-18 15:08     ` Roger Quadros
2013-01-21 11:06     ` [PATCH v9 " Roger Quadros
2013-01-18 12:17 ` [PATCH v8 07/22] mfd: omap-usb-tll: Check for missing platform data in probe Roger Quadros
2013-01-18 12:17 ` [PATCH v8 08/22] mfd: omap-usb-tll: Fix error message Roger Quadros
2013-01-18 12:17 ` [PATCH v8 09/22] mfd: omap-usb-tll: serialize access to TLL device Roger Quadros
2013-01-18 12:17 ` [PATCH v8 10/22] mfd: omap-usb-tll: Add OMAP5 revision and HSIC support Roger Quadros
2013-01-18 12:17 ` [PATCH v8 11/22] mfd: omap_usb_host: Avoid missing platform data checks in suspend/resume Roger Quadros
2013-01-18 12:17 ` [PATCH v8 12/22] mfd: omap-usb-host: Use devm_kzalloc() and devm_request_and_ioremap() Roger Quadros
2013-01-18 12:17 ` [PATCH v8 13/22] mfd: omap-usb-host: know about number of ports from revision register Roger Quadros
2013-01-18 12:17 ` [PATCH v8 14/22] mfd: omap-usb-host: override number of ports from platform data Roger Quadros
2013-01-18 12:17 ` [PATCH v8 15/22] mfd: omap-usb-host: cleanup clock management code Roger Quadros
2013-01-21 11:10   ` [PATCH v9 " Roger Quadros
2013-01-18 12:17 ` [PATCH v8 16/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode Roger Quadros
2013-01-18 12:17 ` [PATCH v8 17/22] mfd: omap-usb-host: Get rid of unnecessary spinlock Roger Quadros
2013-01-21 11:11   ` [PATCH v9 16/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode Roger Quadros
2013-01-18 12:17 ` [PATCH v8 18/22] mfd: omap-usb-host: clean up omap_usbhs_init() Roger Quadros
2013-01-18 12:17 ` [PATCH v8 19/22] ARM: OMAP3: clock data: get rid of unused USB host clock aliases and dummies Roger Quadros
2013-01-18 20:27   ` Paul Walmsley
2013-01-21  9:35     ` Roger Quadros
2013-01-21 15:03       ` Paul Walmsley
2013-01-22  9:28         ` Roger Quadros
2013-02-05 11:22         ` Roger Quadros
2013-02-11 19:49           ` Paul Walmsley
2013-06-09  7:15           ` Paul Walmsley
2013-01-18 12:17 ` [PATCH v8 20/22] ARM: OMAP4: clock data: get rid of unused USB host clock aliases Roger Quadros
2013-01-18 12:17 ` [PATCH v8 21/22] mfd: omap-usb-host: Don't spam console on clk_set_parent failure Roger Quadros
2013-01-18 12:17 ` [PATCH v8 22/22] mdf: omap-usb-host: get rid of build warning Roger Quadros
  -- strict thread matches above, loose matches on Subject: below --
2013-01-18 12:36 [PATCH v8 01/22] USB: ehci-omap: Don't free gpios that we didn't request Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F941CB.1080808@ti.com \
    --to=rogerq@ti.com \
    --cc=balbi@ti.com \
    --cc=bjorn@mork.no \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=sameo@linux.intel.com \
    --cc=sshtylyov@mvista.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox