From: Roger Quadros <rogerq@ti.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: <sameo@linux.intel.com>, <balbi@ti.com>, <tony@atomide.com>,
<kishon@ti.com>, <sshtylyov@mvista.com>, <bjorn@mork.no>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v8 06/22] mfd: omap-usb-tll: introduce and use mode_needs_tll()
Date: Fri, 18 Jan 2013 17:08:05 +0200 [thread overview]
Message-ID: <50F96555.2020402@ti.com> (raw)
In-Reply-To: <20130118150242.GF23505@n2100.arm.linux.org.uk>
On 01/18/2013 05:02 PM, Russell King - ARM Linux wrote:
> On Fri, Jan 18, 2013 at 02:17:09PM +0200, Roger Quadros wrote:
>> +/* only PHY and UNUSED modes don't need TLL */
>> +#define omap_usb_mode_needs_tll(x) ((x != OMAP_USBHS_PORT_MODE_UNUSED) &&\
>> + (x != OMAP_EHCI_PORT_MODE_PHY))
>
> Growl.
>
> These parens do not make anything safer at all - they just obfuscate. The
> safe version of the above macro would have been:
>
> #define omap_usb_mode_needs_tll(x) ((x) != OMAP_USBHS_PORT_MODE_UNUSED &&\
> (x) != OMAP_EHCI_PORT_MODE_PHY)
>
> If you're going to use a macro argument in an expression, it needs parens.
> Simple expressions like a != b && c != d do _not_ need parens.
>
Yikes, that was brain dead stuff from me ;). Will fix.
cheers,
-roger
next prev parent reply other threads:[~2013-01-18 15:08 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 12:17 [PATCH v8 00/22] OMAP USB Host cleanup Roger Quadros
2013-01-18 12:17 ` [PATCH v8 01/22] USB: ehci-omap: Don't free gpios that we didn't request Roger Quadros
2013-01-18 12:36 ` Roger Quadros
2013-01-18 12:17 ` [PATCH v8 02/22] mfd: omap-usb-host: Consolidate OMAP USB-HS platform data Roger Quadros
2013-01-18 12:17 ` [PATCH v8 03/22] mfd: omap-usb-tll: Fix channel count detection Roger Quadros
2013-01-18 12:17 ` [PATCH v8 04/22] mfd: omap-usb-tll: Use devm_kzalloc/ioremap and clean up error path Roger Quadros
2013-01-18 12:17 ` [PATCH v8 05/22] mfd: omap-usb-tll: Clean up clock handling Roger Quadros
2013-01-18 14:59 ` Russell King - ARM Linux
2013-01-18 15:04 ` Roger Quadros
2013-01-21 11:04 ` [PATCH v9 " Roger Quadros
2013-01-21 16:01 ` Russell King - ARM Linux
2013-01-18 12:17 ` [PATCH v8 06/22] mfd: omap-usb-tll: introduce and use mode_needs_tll() Roger Quadros
2013-01-18 15:02 ` Russell King - ARM Linux
2013-01-18 15:08 ` Roger Quadros [this message]
2013-01-21 11:06 ` [PATCH v9 " Roger Quadros
2013-01-18 12:17 ` [PATCH v8 07/22] mfd: omap-usb-tll: Check for missing platform data in probe Roger Quadros
2013-01-18 12:17 ` [PATCH v8 08/22] mfd: omap-usb-tll: Fix error message Roger Quadros
2013-01-18 12:17 ` [PATCH v8 09/22] mfd: omap-usb-tll: serialize access to TLL device Roger Quadros
2013-01-18 12:17 ` [PATCH v8 10/22] mfd: omap-usb-tll: Add OMAP5 revision and HSIC support Roger Quadros
2013-01-18 12:17 ` [PATCH v8 11/22] mfd: omap_usb_host: Avoid missing platform data checks in suspend/resume Roger Quadros
2013-01-18 12:17 ` [PATCH v8 12/22] mfd: omap-usb-host: Use devm_kzalloc() and devm_request_and_ioremap() Roger Quadros
2013-01-18 12:17 ` [PATCH v8 13/22] mfd: omap-usb-host: know about number of ports from revision register Roger Quadros
2013-01-18 12:17 ` [PATCH v8 14/22] mfd: omap-usb-host: override number of ports from platform data Roger Quadros
2013-01-18 12:17 ` [PATCH v8 15/22] mfd: omap-usb-host: cleanup clock management code Roger Quadros
2013-01-21 11:10 ` [PATCH v9 " Roger Quadros
2013-01-18 12:17 ` [PATCH v8 16/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode Roger Quadros
2013-01-18 12:17 ` [PATCH v8 17/22] mfd: omap-usb-host: Get rid of unnecessary spinlock Roger Quadros
2013-01-21 11:11 ` [PATCH v9 16/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode Roger Quadros
2013-01-18 12:17 ` [PATCH v8 18/22] mfd: omap-usb-host: clean up omap_usbhs_init() Roger Quadros
2013-01-18 12:17 ` [PATCH v8 19/22] ARM: OMAP3: clock data: get rid of unused USB host clock aliases and dummies Roger Quadros
2013-01-18 20:27 ` Paul Walmsley
2013-01-21 9:35 ` Roger Quadros
2013-01-21 15:03 ` Paul Walmsley
2013-01-22 9:28 ` Roger Quadros
2013-02-05 11:22 ` Roger Quadros
2013-02-11 19:49 ` Paul Walmsley
2013-06-09 7:15 ` Paul Walmsley
2013-01-18 12:17 ` [PATCH v8 20/22] ARM: OMAP4: clock data: get rid of unused USB host clock aliases Roger Quadros
2013-01-18 12:17 ` [PATCH v8 21/22] mfd: omap-usb-host: Don't spam console on clk_set_parent failure Roger Quadros
2013-01-18 12:17 ` [PATCH v8 22/22] mdf: omap-usb-host: get rid of build warning Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F96555.2020402@ti.com \
--to=rogerq@ti.com \
--cc=balbi@ti.com \
--cc=bjorn@mork.no \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sameo@linux.intel.com \
--cc=sshtylyov@mvista.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox