Re: [PATCH] sched: fix compilation warning

[Randy Dunlap <rdunlap@xenotime.net>]

On 01/18/13 12:47, Cong Ding wrote:
> Is this patch still queued or...?
> 
> - cong

ping.
Can we get this patch or something similar merged, please?


> On Wed, Dec 5, 2012 at 6:10 PM, Cong Ding <dinggnu@gmail.com> wrote:
>> the following compilation warning is caused by Commit-ID:
>> c566e8e9e44b72b53091da20e2dedefc730f2ee2
>>
>> kernel/sched/debug.c: In function ‘print_cfs_rq’:
>> kernel/sched/debug.c:225:2: warning: format ‘%ld’ expects argument of type
>> ‘long int’, but argument 4 has type ‘long long int’ [-Wformat]
>> kernel/sched/debug.c:225:2: warning: format ‘%ld’ expects argument of type
>> ‘long int’, but argument 3 has type ‘long long int’ [-Wformat]
>>
>> where function atomic64_read returns long long int, but %ld was used in the
>> printf
>>
>> Signed-off-by: Cong Ding <dinggnu@gmail.com>
>> ---
>>  kernel/sched/debug.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
>> index 2cd3c1b..83ec463 100644
>> --- a/kernel/sched/debug.c
>> +++ b/kernel/sched/debug.c
>> @@ -222,7 +222,7 @@ void print_cfs_rq(struct seq_file *m, int cpu, struct cfs_rq *cfs_rq)
>>                         cfs_rq->runnable_load_avg);
>>         SEQ_printf(m, "  .%-30s: %lld\n", "blocked_load_avg",
>>                         cfs_rq->blocked_load_avg);
>> -       SEQ_printf(m, "  .%-30s: %ld\n", "tg_load_avg",
>> +       SEQ_printf(m, "  .%-30s: %lld\n", "tg_load_avg",
>>                         atomic64_read(&cfs_rq->tg->load_avg));
>>         SEQ_printf(m, "  .%-30s: %lld\n", "tg_load_contrib",
>>                         cfs_rq->tg_load_contrib);
>> --


-- 
~Randy