From: Jiri Slaby <jslaby@suse.cz>
To: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: Cong Ding <dinggnu@gmail.com>, Mikael Starvik <starvik@axis.com>,
Alan Cox <alan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-cris-kernel <linux-cris-kernel@axis.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tty: serial/crisv10.c: remove unnecessary null pointer check
Date: Sun, 20 Jan 2013 11:14:02 +0100 [thread overview]
Message-ID: <50FBC36A.7080009@suse.cz> (raw)
In-Reply-To: <20130118133821.GQ23529@axis.com>
On 01/18/2013 02:38 PM, Jesper Nilsson wrote:
> On Wed, Jan 16, 2013 at 11:30:44PM +0100, Cong Ding wrote:
>> The pointer tty is dereferened in line 3135, so it is not necessary to check
>> null again in line 3140.
>
> I don't know if we actually need to check the parameter tty from being null,
> but when checking the rest of the file, most other functions don't check it.
Yes, the check in unneeded.
thanks,
--
js
suse labs
prev parent reply other threads:[~2013-01-20 10:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 22:30 [PATCH] tty: serial/68328serial.c: remove unnecessary null pointer check Cong Ding
2013-01-16 22:30 ` [PATCH] tty: serial/crisv10.c: " Cong Ding
2013-01-18 13:38 ` Jesper Nilsson
2013-01-20 10:14 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FBC36A.7080009@suse.cz \
--to=jslaby@suse.cz \
--cc=alan@linux.intel.com \
--cc=dinggnu@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jesper.nilsson@axis.com \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox