From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753060Ab3AVOsJ (ORCPT ); Tue, 22 Jan 2013 09:48:09 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:44435 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752792Ab3AVOsH (ORCPT ); Tue, 22 Jan 2013 09:48:07 -0500 Message-ID: <50FEA696.8000506@ti.com> Date: Tue, 22 Jan 2013 16:47:50 +0200 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: kishon CC: , , , , , , , , , , Subject: Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot References: <1358848694-20145-1-git-send-email-kishon@ti.com> <1358848694-20145-7-git-send-email-kishon@ti.com> <50FE9F5C.2010501@ti.com> <50FEA447.1090701@ti.com> In-Reply-To: <50FEA447.1090701@ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/22/2013 04:37 PM, kishon wrote: > On Tuesday 22 January 2013 07:47 PM, Roger Quadros wrote: >> On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote: >>> The OMAP glue has been modified to get PHY by phandle for dt boot. >>> >>> Signed-off-by: Kishon Vijay Abraham I >>> --- >>> drivers/usb/musb/omap2430.c | 7 ++++++- >>> 1 file changed, 6 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c >>> index 1a8cf6d..e43faeb 100644 >>> --- a/drivers/usb/musb/omap2430.c >>> +++ b/drivers/usb/musb/omap2430.c >>> @@ -345,7 +345,12 @@ static int omap2430_musb_init(struct musb *musb) >>> * up through ULPI. TWL4030-family PMICs include one, >>> * which needs a driver, drivers aren't always needed. >>> */ >>> - musb->xceiv = devm_usb_get_phy_dev(dev, 0); >>> + if (dev->parent->of_node) >>> + musb->xceiv = devm_usb_get_phy_by_phandle(dev->parent, >>> + "usb_phy", 0); >>> + else >>> + musb->xceiv = devm_usb_get_phy_dev(dev, 0); >>> + >>> if (IS_ERR_OR_NULL(musb->xceiv)) { >>> pr_err("HS USB OTG: no transceiver configured\n"); >>> return -ENODEV; >> >> This will not work with PHY driver as a module. You need to use deferred probing mechanism here >> after you have addressed my comment in patch 2 and also devm_usb_get_phy_by_phandle() > > IIUC, even using -EPROBE_DEFER might not help if we are making the PHY driver as module, since the kernel will try to probe only till the prompt comes. > Oh really? I thought deferred probing takes place whenever a new driver is bound to a device. What does "prompt comes" have to do with it? > And having -EPROBE_DEFER instead of -ENODEV might also not help since, the gadget driver wont be able to bind to UDC (usb_gadget_probe_driver will fail). > > A lot of things need to be changed before we change to -EPROBE_DEFER IMO. OK. -- cheers, -roger