Re: [PATCH 1/2] coccicheck: Allow the user to give a VERBOSE= argument

[Bernd Schubert <bernd.schubert@itwm.fraunhofer.de>]

Hello Nicolas,

On 01/22/2013 03:31 PM, Nicolas Palix wrote:
> Hi,
>
> Thank you Bernd for your proposition.
>
> I added Michal in CC, who is responsible for the integration.

Oh, sorry, I CCed everyone, but forgot Michal.

>
> I was wondering if the V variable which already exists would not be better
> than introducing a new variable. Bernd, is there any reason to not use V ?

I'm fine using 'V' either.

>
> Your patch also remove the check of the ONLINE variable. In doing so,
> I think that your patch will badly interfere with the online checking
> performed with the C variable. Am I missing something ?

Hmm, I probably should have told in the patch description that verbosity 
defaults to 0 now. Shall I revert or make an extra patch for that? With 
the current patch and ONLINE != 0 nothing will change.


Cheers,
Bernd


>
> Regards,
>
> On Tue, Jan 22, 2013 at 2:34 PM, Bernd Schubert
> <bernd.schubert@itwm.fraunhofer.de> wrote:
>> Simply running "make coccicheck" returns very verbose output and warnings
>> might not be noticed.  Allow the user to set the verbosity level.
>>
>>
>> Signed-off-by: Bernd Schubert <bernd.schubert@itwm.fraunhofer.de>
>> CC: Julia Lawall <Julia.Lawall@lip6.fr>
>> CC: Nicolas Palix <nicolas.palix@imag.fr>
>> CC: cocci@systeme.lip6.fr
>> ---
>>   scripts/coccicheck |    8 +++++++-
>>   1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/coccicheck b/scripts/coccicheck
>> index 1a49d1c..eab0b00 100755
>> --- a/scripts/coccicheck
>> +++ b/scripts/coccicheck
>> @@ -2,6 +2,12 @@
>>
>>   SPATCH="`which ${SPATCH:=spatch}`"
>>
>> +if [ -z "$VERBOSE" ] ; then
>> +       RUN_VERBOSE=0
>> +else
>> +       RUN_VERBOSE=$VERBOSE
>> +fi
>> +
>>   if [ "$C" = "1" -o "$C" = "2" ]; then
>>       ONLINE=1
>>
>> @@ -55,7 +61,7 @@ coccinelle () {
>>   #
>>   #    $SPATCH -D $MODE $FLAGS -parse_cocci $COCCI $OPT > /dev/null
>>
>> -    if [ "$ONLINE" = "0" ] ; then
>> +    if [ "$RUN_VERBOSE" != "0" ] ; then
>>
>>          FILE=`echo $COCCI | sed "s|$srctree/||"`
>>
>>
>
>
>