From: Stephen Warren <swarren@wwwdotorg.org>
To: Alex Courbot <acourbot@nvidia.com>
Cc: Thierry Reding <thierry.reding@avionic-design.de>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Mark Zhang <markz@nvidia.com>,
"gnurou@gmail.com" <gnurou@gmail.com>
Subject: Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver
Date: Tue, 22 Jan 2013 09:30:03 -0700 [thread overview]
Message-ID: <50FEBE8B.60101@wwwdotorg.org> (raw)
In-Reply-To: <12033649.LY58cllSHv@percival>
On 01/21/2013 08:24 PM, Alex Courbot wrote:
> On Tuesday 22 January 2013 01:46:33 Stephen Warren wrote:
>>> arch/arm/boot/dts/tegra20-ventana.dts | 18 +++-
>>> arch/arm/configs/tegra_defconfig | 1 +
>>> drivers/video/backlight/Kconfig | 7 ++
>>> drivers/video/backlight/pwm_bl.c | 3 +
>>> drivers/video/backlight/pwm_bl_tegra.c | 159
>>> +static struct pwm_backlight_subdriver pwm_backlight_ventana_subdriver = {
>>> + .name = "pwm-backlight-ventana",
>>> + .init = init_ventana,
>>> + .exit = exit_ventana,
>>> + .notify = notify_ventana,
>>> + .notify_after = notify_after_ventana,
>>> +};
>>
>> It seems like all of that code should be completely generic.
>
> Sorry, I don't get your point here - could you elaborate?
Nothing there (i.e. in the body of any of those functions) seems
remotely specific to Ventana or even Ventana's panel; presumably it
would work for any built-in LCD panel?
next prev parent reply other threads:[~2013-01-22 16:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-19 10:30 [PATCH 0/3] pwm-backlight: add subdrivers & Tegra support Alexandre Courbot
2013-01-19 10:30 ` [PATCH 1/3] pwm-backlight: add subdriver mechanism Alexandre Courbot
2013-01-19 10:30 ` [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver Alexandre Courbot
2013-01-21 7:35 ` Mark Zhang
2013-01-21 8:24 ` Alex Courbot
2013-01-21 8:35 ` Mark Zhang
2013-01-21 8:52 ` Marc Dietrich
2013-01-21 8:55 ` Mark Zhang
2013-01-21 17:46 ` Stephen Warren
2013-01-22 3:24 ` Alex Courbot
2013-01-22 7:06 ` Thierry Reding
2013-01-23 9:45 ` Alex Courbot
2013-01-24 6:10 ` Alex Courbot
2013-01-22 16:30 ` Stephen Warren [this message]
2013-01-23 10:15 ` Leela Krishna Amudala
2013-01-23 10:29 ` Alex Courbot
2013-01-19 10:30 ` [PATCH 3/3] tegra: ventana: of: add host1x device to DT Alexandre Courbot
2013-01-20 3:38 ` [PATCH 0/3] pwm-backlight: add subdrivers & Tegra support Mark Zhang
2013-01-20 5:26 ` Alexandre Courbot
2013-01-20 5:51 ` Mark Zhang
2013-01-21 2:09 ` Mark Zhang
2013-01-21 2:59 ` Mark Zhang
2013-01-21 7:49 ` Thierry Reding
2013-01-21 8:18 ` Alex Courbot
2013-01-22 7:17 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FEBE8B.60101@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=acourbot@nvidia.com \
--cc=gnurou@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=markz@nvidia.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox