linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Wang <wangyun@linux.vnet.ibm.com>
To: Mike Galbraith <bitbucket@online.de>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
	peterz@infradead.org, mingo@kernel.org, a.p.zijlstra@chello.nl
Subject: Re: [RFC PATCH 0/2] sched: simplify the select_task_rq_fair()
Date: Wed, 23 Jan 2013 10:44:48 +0800	[thread overview]
Message-ID: <50FF4EA0.1070000@linux.vnet.ibm.com> (raw)
In-Reply-To: <1358865692.5782.420.camel@marge.simpson.net>

On 01/22/2013 10:41 PM, Mike Galbraith wrote:
> On Tue, 2013-01-22 at 16:56 +0800, Michael Wang wrote:
> 
>> What about this patch? May be the wrong map is the killer on balance
>> path, should we check it? ;-) 
> 
> [    1.232249] Brought up 40 CPUs
> [    1.236003] smpboot: Total of 40 processors activated (180873.90 BogoMIPS)
> [    1.244744] CPU0 attaching sched-domain:
> [    1.254131] NMI watchdog: enabled on all CPUs, permanently consumes one hw-PMU counter.
> [    1.252010]  domain 0: span 0,16 level SIBLING
> [    1.280001]   groups: 0 (cpu_power = 589) 16 (cpu_power = 589)
> [    1.292540]   domain 1: span 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38 level MC
> [    1.312001]    groups: 0,16 (cpu_power = 1178) 2,18 (cpu_power = 1178) 4,20 (cpu_power = 1178) 6,22 (cpu_power = 1178) 8,24 (cpu_power = 1178)
>                          10,26 (cpu_power = 1178)12,28 (cpu_power = 1178)14,30 (cpu_power = 1178)32,36 (cpu_power = 1178)34,38 (cpu_power = 1178)
> [    1.368002]    domain 2: span 0-39 level NUMA
> [    1.376001]     groups: 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38 (cpu_power = 11780)
>                            1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39 (cpu_power = 11780)

Thanks for the testing, that's not all the output but just for cpu 0,
correct?

> [    1.412546] WYT: sbm of cpu 0
> [    1.416001] WYT:      exec map
> [    1.424002] WYT:              sd 6ce55000, idx 0, level 0, weight 2
> [    1.436001] WYT:              sd 6ce74000, idx 1, level 1, weight 20
> [    1.448001] WYT:              sd 6cef3000, idx 3, level 3, weight 40
> [    1.460001] WYT:      fork map
> [    1.468001] WYT:              sd 6ce55000, idx 0, level 0, weight 2
> [    1.480001] WYT:              sd 6ce74000, idx 1, level 1, weight 20

This is not by design... sd in idx 2 should point to level 1 sd if there
is no level 2 sd, this part is broken...oh, how could level 3 sd be
there with out level 2 created? strange...

So with this map, the new balance path will no doubt broken, I think we
got the reason, amazing ;-)

Let's see how to fix it, hmm... need some study firstly.

Regards,
Michael Wang

> [    1.492001] WYT:              sd 6cef3000, idx 3, level 3, weight 40
> [    1.504001] WYT:      wake map
>                                  Hi, we're not home right now...
> [    1.508001] WYT:      affine map
> [    1.516001] WYT:              affine with cpu 0 in sd 6ce55000, weight 2
> [    1.528001] WYT:              affine with cpu 1 in sd 6cef3000, weight 40
> [    1.544001] WYT:              affine with cpu 2 in sd 6ce74000, weight 20
> [    1.556001] WYT:              affine with cpu 3 in sd 6cef3000, weight 40
> [    1.568001] WYT:              affine with cpu 4 in sd 6ce74000, weight 20
> [    1.584001] WYT:              affine with cpu 5 in sd 6cef3000, weight 40
> [    1.596001] WYT:              affine with cpu 6 in sd 6ce74000, weight 20
> [    1.608001] WYT:              affine with cpu 7 in sd 6cef3000, weight 40
> [    1.624001] WYT:              affine with cpu 8 in sd 6ce74000, weight 20
> [    1.636001] WYT:              affine with cpu 9 in sd 6cef3000, weight 40
> [    1.648001] WYT:              affine with cpu a in sd 6ce74000, weight 20
> [    1.660001] WYT:              affine with cpu b in sd 6cef3000, weight 40
> [    1.676001] WYT:              affine with cpu c in sd 6ce74000, weight 20
> [    1.688001] WYT:              affine with cpu d in sd 6cef3000, weight 40
> [    1.700001] WYT:              affine with cpu e in sd 6ce74000, weight 20
> [    1.716001] WYT:              affine with cpu f in sd 6cef3000, weight 40
> [    1.728001] WYT:              affine with cpu 10 in sd 6ce55000, weight 2
> [    1.740001] WYT:              affine with cpu 11 in sd 6cef3000, weight 40
> [    1.756001] WYT:              affine with cpu 12 in sd 6ce74000, weight 20
> [    1.768001] WYT:              affine with cpu 13 in sd 6cef3000, weight 40
> [    1.780001] WYT:              affine with cpu 14 in sd 6ce74000, weight 20
> [    1.796001] WYT:              affine with cpu 15 in sd 6cef3000, weight 40
> [    1.808001] WYT:              affine with cpu 16 in sd 6ce74000, weight 20
> [    1.820001] WYT:              affine with cpu 17 in sd 6cef3000, weight 40
> [    1.836001] WYT:              affine with cpu 18 in sd 6ce74000, weight 20
> [    1.848001] WYT:              affine with cpu 19 in sd 6cef3000, weight 40
> [    1.860001] WYT:              affine with cpu 1a in sd 6ce74000, weight 20
> [    1.876001] WYT:              affine with cpu 1b in sd 6cef3000, weight 40
> [    1.888001] WYT:              affine with cpu 1c in sd 6ce74000, weight 20
> [    1.900001] WYT:              affine with cpu 1d in sd 6cef3000, weight 40
> [    1.916001] WYT:              affine with cpu 1e in sd 6ce74000, weight 20
> [    1.928001] WYT:              affine with cpu 1f in sd 6cef3000, weight 40
> [    1.940001] WYT:              affine with cpu 20 in sd 6ce74000, weight 20
> [    1.956001] WYT:              affine with cpu 21 in sd 6cef3000, weight 40
> [    1.968001] WYT:              affine with cpu 22 in sd 6ce74000, weight 20
> [    1.984001] WYT:              affine with cpu 23 in sd 6cef3000, weight 40
> [    1.996001] WYT:              affine with cpu 24 in sd 6ce74000, weight 20
> [    2.008002] WYT:              affine with cpu 25 in sd 6cef3000, weight 40
> [    2.024002] WYT:              affine with cpu 26 in sd 6ce74000, weight 20
> [    2.036001] WYT:              affine with cpu 27 in sd 6cef3000, weight 40


> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 


  reply	other threads:[~2013-01-23  2:45 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1356588535-23251-1-git-send-email-wangyun@linux.vnet.ibm.com>
2013-01-09  9:28 ` [RFC PATCH 0/2] sched: simplify the select_task_rq_fair() Michael Wang
2013-01-12  8:01   ` Mike Galbraith
2013-01-12 10:19     ` Mike Galbraith
2013-01-14  9:21       ` Mike Galbraith
2013-01-15  3:10         ` Michael Wang
2013-01-15  4:52           ` Mike Galbraith
2013-01-15  8:26             ` Michael Wang
2013-01-17  5:55         ` Michael Wang
2013-01-20  4:09           ` Mike Galbraith
2013-01-21  2:50             ` Michael Wang
2013-01-21  4:38               ` Mike Galbraith
2013-01-21  5:07                 ` Michael Wang
2013-01-21  6:42                   ` Mike Galbraith
2013-01-21  7:09                     ` Mike Galbraith
2013-01-21  7:45                       ` Michael Wang
2013-01-21  9:09                         ` Mike Galbraith
2013-01-21  9:22                           ` Michael Wang
2013-01-21  9:44                             ` Mike Galbraith
2013-01-21 10:30                               ` Mike Galbraith
2013-01-22  3:43                               ` Michael Wang
2013-01-22  8:03                                 ` Mike Galbraith
2013-01-22  8:56                                   ` Michael Wang
2013-01-22 11:34                                     ` Mike Galbraith
2013-01-23  3:01                                       ` Michael Wang
2013-01-23  5:02                                         ` Mike Galbraith
2013-01-22 14:41                                     ` Mike Galbraith
2013-01-23  2:44                                       ` Michael Wang [this message]
2013-01-23  4:31                                         ` Mike Galbraith
2013-01-23  5:09                                           ` Michael Wang
2013-01-23  6:28                                             ` Mike Galbraith
2013-01-23  7:10                                               ` Michael Wang
2013-01-23  8:20                                                 ` Mike Galbraith
2013-01-23  8:30                                                   ` Michael Wang
2013-01-23  8:49                                                     ` Mike Galbraith
2013-01-23  9:00                                                       ` Michael Wang
2013-01-23  9:18                                                         ` Mike Galbraith
2013-01-23  9:26                                                           ` Michael Wang
2013-01-23  9:37                                                             ` Mike Galbraith
2013-01-23  9:32                                                           ` Mike Galbraith
2013-01-24  6:01                                                             ` Michael Wang
2013-01-24  6:51                                                               ` Mike Galbraith
2013-01-24  7:15                                                                 ` Michael Wang
2013-01-24  7:47                                                                   ` Mike Galbraith
2013-01-24  8:14                                                                     ` Michael Wang
2013-01-24  9:07                                                                       ` Mike Galbraith
2013-01-24  9:26                                                                         ` Michael Wang
2013-01-24 10:34                                                                           ` Mike Galbraith
2013-01-25  2:14                                                                             ` Michael Wang
2013-01-24  7:00                                                               ` Michael Wang
2013-01-21  7:34                     ` Michael Wang
2013-01-21  8:26                       ` Mike Galbraith
2013-01-21  8:46                         ` Michael Wang
2013-01-21  9:11                           ` Mike Galbraith
2013-01-15  2:46     ` Michael Wang
2013-01-11  8:15 Michael Wang
2013-01-11 10:13 ` Nikunj A Dadhania
2013-01-15  2:20   ` Michael Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50FF4EA0.1070000@linux.vnet.ibm.com \
    --to=wangyun@linux.vnet.ibm.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=bitbucket@online.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).