public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Is this a bug that n_tty_set_room not serialized? If so please correct it.
@ 2013-01-23  2:46 snakky.zhang
  0 siblings, 0 replies; 3+ messages in thread
From: snakky.zhang @ 2013-01-23  2:46 UTC (permalink / raw)
  To: linux-kernel

Hi experts,

Seems there is an bug related to function n_tty_set_roomin source file
drivers/tty/n_tty.c. This function is used to set receive_room based on
the read_cntby both the consumer and the producer of the tty's read buffer.

But this function is not serialized, so I am afraid there is
a risk like: The producer make the buffer full and then call this 
function to
set the receive_room to 0; while it is preempted by the consumer that empty
the buffer(read_cnt is 0)and then call this very function to set the
receive_room to a non-zero value. But when the producer continue, 
receive_room
was set to 0 again. Thus both read_cnt and receive_room is 0.For consumer
theread_cnt is 0 that no data can be read; while for the producer, thebuffer
is full since the receive_room is 0. Both of them blockhere...

Two methods to avoid it:
A) Addor find a lock to serialize this function;
B) Once the producer find the buffer is full, double check/set the 
buffer with
n_tty_set_room. For example in function "flush_to_ldisc".

Please correct me if I misunderstand something. Or please fix it.

Thanks
Xiao

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Is this a bug that n_tty_set_room not serialized? If so please correct it.
@ 2013-01-23  4:40 snakky.zhang
  2013-01-23 14:35 ` Alan Cox
  0 siblings, 1 reply; 3+ messages in thread
From: snakky.zhang @ 2013-01-23  4:40 UTC (permalink / raw)
  To: linux-kernel

Hi experts,

Seems there is an bug related to function n_tty_set_roomin source file
drivers/tty/n_tty.c. This function is used to set receive_room based on
the read_cntby both the consumer and the producer of the tty's read buffer.

But this function is not serialized, so I am afraid there is
a risk like: The producer make the buffer full and then call this 
function to
set the receive_room to 0; while it is preempted by the consumer that empty
the buffer(read_cnt is 0)and then call this very function to set the
receive_room to a non-zero value. But when the producer continue, 
receive_room
was set to 0 again. Thus both read_cnt and receive_room is 0.For consumer
theread_cnt is 0 that no data can be read; while for the producer, 
thebuffer
is full since the receive_room is 0. Both of them blockhere...

Two methods to avoid it:
A) Addor find a lock to serialize this function;
B) Once the producer find the buffer is full, double check/set the 
buffer with
n_tty_set_room. For example in function "flush_to_ldisc".

Please correct me if I misunderstand something. Or please fix it.

Thanks
Xiao

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-23 14:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-23  2:46 Is this a bug that n_tty_set_room not serialized? If so please correct it snakky.zhang
  -- strict thread matches above, loose matches on Subject: below --
2013-01-23  4:40 snakky.zhang
2013-01-23 14:35 ` Alan Cox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox