From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Luciano Coelho <coelho@ti.com>
Cc: Tony Lindgren <tony@atomide.com>, <gregkh@linuxfoundation.org>,
<balbi@ti.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "drivers/misc/ti-st: remove gpio handling"
Date: Wed, 23 Jan 2013 10:05:57 +0100 [thread overview]
Message-ID: <50FFA7F5.1000104@ti.com> (raw)
In-Reply-To: <50FFA7A9.9040709@ti.com>
On 01/23/2013 10:04 AM, Peter Ujfalusi wrote:
> On 01/22/2013 10:31 PM, Luciano Coelho wrote:
>> I thought about checking exactly what we need as delays and whether we
>> really need to do all that toggling. At least in some boards, the
>> toggles are not needed, but I don't know for sure whether it works in
>> all different variations of the chip, so I kept them to be safe. Also,
>> I tried to deviate as little as possible from a plain revert, since I'd
>> like to get this into stable as well.
>
> I can not find the documentation for the WiLink, but I would guess that it
> needs some delay between high->low(off)->(wait)->high(on)->(power-on-time)->up
But mdelay() looks a bit overkill IMHO.
--
Péter
next prev parent reply other threads:[~2013-01-23 9:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 11:12 [PATCH] Revert "drivers/misc/ti-st: remove gpio handling" Luciano Coelho
2013-01-22 20:14 ` Tony Lindgren
2013-01-22 21:31 ` Luciano Coelho
2013-01-23 9:04 ` Peter Ujfalusi
2013-01-23 9:05 ` Peter Ujfalusi [this message]
2013-01-23 9:14 ` Luciano Coelho
2013-01-23 9:21 ` Peter Ujfalusi
2013-01-23 9:28 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FFA7F5.1000104@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=balbi@ti.com \
--cc=coelho@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox