From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C71242A146 for ; Tue, 7 Jul 2026 14:28:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783434502; cv=none; b=orFdJ+xLcVpg8wFh9lDlm51m7qWGoP1PoRyIXIIy7XcvfXzwsRCxw3jMNvOBZAwRPKvj8dZWKFTbE9xevngLgCLXO5DGEJIEhFkX7AzJeWU+nzNGGL0U9gGcZR4mU974ruL4I4x8XpuvKIzsC3uogkoRIN1W6W/ec/KqkgBJAmg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783434502; c=relaxed/simple; bh=4xvnIfvNfhPDvES0mxN/pGbc5CjhlyU3C5SGy/aHe4Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RAAC4Wc1SGs8bQqsY9JADBjAraKinbaT7tmEFTKCywglycu3+ZtnKovtPpdPjwpfC4UOyYiHG3Y+O0vRfL7LsXx4ILLosEuZqUGVPbb3D1XkuwIPvtiGmoQ2z0KFoizP5bu5ODLXOszta/CSxKijdNzZs0AgXhOHFtkIeFrGN4Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lLUj0RXq; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lLUj0RXq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0412B1F000E9; Tue, 7 Jul 2026 14:28:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783434499; bh=SMQ8K9VfUIpA2XT73iQzn2WJ6V6USrzYPAEG4w2/L94=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=lLUj0RXqa3eqVSWa8s3jcLRzvPAoxXywuBBbtB7eGxbsslO52vc2uQi76DXyAQ/Uo 1k6hzKcGoTWdwSskzPk3fXkyS9wDJBndvI1/c30aawuCArJtFmFwmY9YZgO2W5sYhA VtkeOJPuAyGMaSKSmRPT7NYc5h7dJub2XY4T0rfN9irI/IK/bPx8eTLkcQiHcRn54G e+UzX8IH0ElSGDmyTkrpcdLutlBYQD1dnghqosFDVj3CpzhE6Z8XE+HWqUiG+4qFve LqZ95gSpLLgfHSfmBOupEsM9hAon1Vx2suTZp2jDGzZYloHcDfyZjpnpdTJkeyW3Z7 UyXmhFnuBFB0g== Message-ID: <50b0de85-0bb9-4d09-b32e-31a3a4661379@kernel.org> Date: Tue, 7 Jul 2026 16:28:14 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] mm/rmap: add anon folio unmap dispatcher function To: Dev Jain , akpm@linux-foundation.org, ljs@kernel.org, muchun.song@linux.dev, osalvador@suse.de Cc: riel@surriel.com, liam@infradead.org, vbabka@kernel.org, harry@kernel.org, jannh@google.com, lance.yang@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ryan.roberts@arm.com, anshuman.khandual@arm.com References: <20260707121128.373192-1-dev.jain@arm.com> <20260707121128.373192-6-dev.jain@arm.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20260707121128.373192-6-dev.jain@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/7/26 14:11, Dev Jain wrote: > Add ttu_anon_folio() as the common entry point for anonymous folio > unmapping. It dispatches to the lazyfree or swapbacked helper as > appropriate, and centralizes restoration of cleared PTEs on failure. > > No functional change intended. > > Signed-off-by: Dev Jain > --- > mm/rmap.c | 59 +++++++++++++++++++++++++++++++++---------------------- > 1 file changed, 36 insertions(+), 23 deletions(-) > > diff --git a/mm/rmap.c b/mm/rmap.c > index ade78df5be2bd..f021ecd51a4a2 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -2171,6 +2171,40 @@ static inline bool ttu_anon_swapbacked_folio(struct vm_area_struct *vma, struct > return true; > } > > +static inline bool ttu_anon_folio(struct vm_area_struct *vma, struct folio *folio, > + struct page *subpage, unsigned long address, pte_t *ptep, > + pte_t pteval, unsigned long nr_pages) > +{ > + struct mm_struct *mm = vma->vm_mm; > + bool ret; > + > + /* > + * Store the swap location in the pte. > + * See handle_pte_fault() ... > + */ > + if (unlikely(folio_test_swapbacked(folio) != > + folio_test_swapcache(folio))) { > + WARN_ON_ONCE(1); > + return false; > + } > + > + /* MADV_FREE page check */ > + if (!folio_test_swapbacked(folio)) { > + ret = ttu_anon_lazyfree_folio(vma, folio); > + if (ret) > + add_mm_counter(mm, MM_ANONPAGES, -nr_pages); Can't the be handled in there as well? > + } else { > + /* nr_pages > 1 not supported yet */ > + ret = ttu_anon_swapbacked_folio(vma, folio, subpage, address, > + ptep, pteval); > + } > + > + if (!ret) > + set_ptes(mm, address, ptep, pteval, nr_pages); It might be cleaner to do that in the caller, where we actually removed the ptes in the first place? > + > + return ret; > +} > + > /* > * @arg: enum ttu_flags will be passed to this argument > */ > @@ -2351,31 +2385,10 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, > */ > dec_mm_counter(mm, mm_counter(folio)); > } else if (folio_test_anon(folio)) { > - /* > - * Store the swap location in the pte. > - * See handle_pte_fault() ... > - */ > - if (unlikely(folio_test_swapbacked(folio) != > - folio_test_swapcache(folio))) { > - WARN_ON_ONCE(1); > + if (!ttu_anon_folio(vma, folio, subpage, address, > + pvmw.pte, pteval, nr_pages)) > goto walk_abort; > - } > > - /* MADV_FREE page check */ > - if (!folio_test_swapbacked(folio)) { > - if (!ttu_anon_lazyfree_folio(vma, folio)) { > - set_ptes(mm, address, pvmw.pte, pteval, nr_pages); > - goto walk_abort; > - } > - add_mm_counter(mm, MM_ANONPAGES, -nr_pages); > - goto finish_unmap; > - } > - > - if (!ttu_anon_swapbacked_folio(vma, folio, subpage, address, > - pvmw.pte, pteval)) { > - set_pte_at(mm, address, pvmw.pte, pteval); > - goto walk_abort; > - } > goto finish_unmap; > } else { > /* Very nice. -- Cheers, David