From: Gao Xiang <gaoxiang25@huawei.com>
To: Chao Yu <yuchao0@huawei.com>, zhong jiang <zhongjiang@huawei.com>
Cc: <gregkh@linuxfoundation.org>, <rspringer@google.com>,
<jnjoseph@google.com>, <benchan@chromium.org>,
"linux-erofs@lists.ozlabs.org" <linux-erofs@lists.ozlabs.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/staging: Remove some unneeded semicolon
Date: Mon, 6 Aug 2018 10:07:56 +0800 [thread overview]
Message-ID: <50b97db3-8cd3-fe68-e23a-d6366f9c014b@huawei.com> (raw)
In-Reply-To: <e80780ed-42c8-3f8c-9197-1c6ac386fb30@huawei.com>
Hi Chao,
On 2018/8/6 9:58, Chao Yu wrote:
> Hi Xiang,
>
> On 2018/8/6 9:27, Gao Xiang wrote:
>> Hi Jiang,
>>
>> On 2018/8/5 21:57, zhong jiang wrote:
>>> That semicolons are unneeded, JUst remove them.
>>>
>>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>>
>> Thanks for your patch. Since erofs and gasket are different feature, it is better to seperate into two patches.
>> and could you please cc linux-erofs mailing list <linux-erofs@lists.ozlabs.org> as well?
>>
>> Yes, there is an extra semicolon in z_erofs_vle_unzip_all, it was reported by Julia Lawall several days ago.
>> Actually, there is a patch in linux-erofs mailing list, but it seems that Chao hasn't reviewed it yet...
>
> Oh, sorry, I missed this one, let me check/review all recent patches again and
> update them in tree later.
>
> Thanks,
It is nothing. :) I will send v2 version of this patch if zhong jiang doesn't mind.
Thanks,
Gao Xiang
>
>>
>> https://lists.ozlabs.org/pipermail/linux-erofs/2018-August/000303.html
>>
>> I will add Signed-off-by: zhong jiang <zhongjiang@huawei.com> to the original patch if if you don't mind, do you?
>>
>> Thanks,
>> Gao Xiang
>>
>> .
>>
>
next prev parent reply other threads:[~2018-08-06 2:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-05 13:57 [PATCH] drivers/staging: Remove some unneeded semicolon zhong jiang
2018-08-06 1:27 ` Gao Xiang
2018-08-06 1:58 ` Chao Yu
2018-08-06 2:07 ` Gao Xiang [this message]
2018-08-06 2:11 ` zhong jiang
2018-08-06 2:16 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50b97db3-8cd3-fe68-e23a-d6366f9c014b@huawei.com \
--to=gaoxiang25@huawei.com \
--cc=benchan@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jnjoseph@google.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rspringer@google.com \
--cc=yuchao0@huawei.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox