From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F78BC00A5A for ; Thu, 19 Jan 2023 15:59:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231491AbjASP7p (ORCPT ); Thu, 19 Jan 2023 10:59:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231496AbjASP7W (ORCPT ); Thu, 19 Jan 2023 10:59:22 -0500 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07C4D829AB; Thu, 19 Jan 2023 07:59:22 -0800 (PST) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30JFvt33004567; Thu, 19 Jan 2023 15:59:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=yXSzOe78bmal4kIb7z2EWqNUVHkYDA0n1ct8HUZCW3s=; b=OjUeyRRoXH0ck5EPn/ym6jAnMMDnLoKf9WgjlD8kIRFrS83lTE/ZU7MY6lYjmLK8PQgQ cJBi8fGfR2BOXyBH1bI7U5BeH24eFd0XCyq4SjAdAsSFS9Mxh7xJoriL3FU7cvJySfFe 4b8MOTmsm4s6pusW1US3DYUMH6FvKVy/QVA2/HPCPWFBErwA1ht0pAZofA5zOkfXBjzZ 0NAwA1p6yeItjwGB8oI0TKbM73AGNUSeQaij2YOfh9yf70ULTqplk61X5ZcMt7x8a0WK 8EDUJqDifiD7TOPROwTlIHTGvXgIIMKbWScZnhaGhY9wqs2pmxKOP9Xulq/nLJYb6fOB xQ== Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3n78vyr5se-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Jan 2023 15:59:07 +0000 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 30JESijd025481; Thu, 19 Jan 2023 15:59:06 GMT Received: from smtprelay02.wdc07v.mail.ibm.com ([9.208.129.120]) by ppma04dal.us.ibm.com (PPS) with ESMTPS id 3n3m18690n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Jan 2023 15:59:06 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 30JFx5qC66126290 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Jan 2023 15:59:05 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E916E58059; Thu, 19 Jan 2023 15:59:04 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C68B75804B; Thu, 19 Jan 2023 15:59:02 +0000 (GMT) Received: from [9.160.87.67] (unknown [9.160.87.67]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Thu, 19 Jan 2023 15:59:02 +0000 (GMT) Message-ID: <50c22529-e0f4-9124-fdc0-c8da49300b18@linux.ibm.com> Date: Thu, 19 Jan 2023 10:59:02 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v4 4/7] s390/pci: Use dma-iommu layer To: Niklas Schnelle , Joerg Roedel , Will Deacon , Robin Murphy , Jason Gunthorpe , Wenjia Zhang Cc: Gerd Bayer , Pierre Morel , iommu@lists.linux.dev, linux-s390@vger.kernel.org, borntraeger@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com, svens@linux.ibm.com, linux-kernel@vger.kernel.org, Julian Ruess References: <20230104120543.308933-1-schnelle@linux.ibm.com> <20230104120543.308933-5-schnelle@linux.ibm.com> <71b9e85d-960f-7403-0113-135746127f3b@linux.ibm.com> Content-Language: en-US From: Matthew Rosato In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 4DVyYk4fvk_4ScoQuW2JIkmImn4PfeC6 X-Proofpoint-GUID: 4DVyYk4fvk_4ScoQuW2JIkmImn4PfeC6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-19_09,2023-01-19_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 mlxlogscore=754 clxscore=1015 suspectscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 phishscore=0 impostorscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301190125 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/19/23 6:03 AM, Niklas Schnelle wrote: >>>>>>>>>>>>>>>>>   >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>  static char *pci_sw_names[] = { >>>>>>>>>>>>>>>>> - "Allocated pages", >>>>>>>>>>>>>>>>> +/* TODO "Allocated pages", */ >>>>>>>>> >>>>>>>>> ? Forgot to finish this? > > Definitely forgot to remove the TODO. I think my latest plan was to > just remove this counter. With the DMA API conversion the > dma_map_ops.alloc and dma_map_ops.free move to common code and I don't > see how we could differentiate these from map/unmap on our side. I'm > not sure how helpful this counter really is either. If you're > interested in how many pages are mapped long term I think it makes more > sense to look at the difference between mapped and unmapped pages. What > do you think? >>>>>>>> Sounds reasonable to me, but I also note that without this series, when viewing statistics for a device, mapped - unmapped != allocated. Maybe allocated pages was already broken, or is it taking into account something else that mapped - unmapped would not (maybe mapping the same page multiple times)?