From: Krzysztof Kozlowski <krzk@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>,
rashmi.a@intel.com, ulf.hansson@linaro.org,
michal.simek@xilinx.com, linux-mmc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kishon@ti.com, vkoul@kernel.org,
andriy.shevchenko@linux.intel.com, linux-phy@lists.infradead.org,
mgross@linux.intel.com
Cc: kris.pan@linux.intel.com, mahesh.r.vaidya@intel.com,
nandhini.srikandan@intel.com, vasavi.v.itha@intel.com,
kenchappa.demakkanavar@intel.com, furong.zhou@intel.com,
mallikarjunappa.sangannavar@intel.com
Subject: Re: [PATCH v1 2/4] Revert "dt-bindings: mmc: Add bindings for Intel Thunder Bay SoC"
Date: Thu, 9 Mar 2023 15:57:36 +0100 [thread overview]
Message-ID: <50c2b5de-4aed-ebd5-86e9-55813e740869@kernel.org> (raw)
In-Reply-To: <ef2f8faf-76cc-d221-8281-cc7b8cb68485@intel.com>
On 09/03/2023 15:12, Adrian Hunter wrote:
> On 24/01/23 13:31, Krzysztof Kozlowski wrote:
>> On 24/01/2023 06:44, rashmi.a@intel.com wrote:
>>> From: "A, Rashmi" <rashmi.a@intel.com>
>>>
>>> This reverts commit ab991c05c42853f0b6110022db9bf30fcc6323dd.
>>
>> Please use scripts/get_maintainers.pl to get a list of necessary people
>> and lists to CC. It might happen, that command when run on an older
>> kernel, gives you outdated entries. Therefore please be sure you base
>> your patches on recent Linux kernel.
>>
>>>
>>> Revert Thunder Bay specific code as the product got cancelled
>>> and there are no end customers.
>>>
>>> Signed-off-by: A, Rashmi <rashmi.a@intel.com>
>>> Reviewed-by: Hunter, Adrian <adrian.hunter@intel.com>wq
>>
>> Stray characters.
>>
>>> ---
>>> .../devicetree/bindings/mmc/arasan,sdhci.yaml | 25 -------------------
>>> 1 file changed, 25 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
>>> index 4053de758db6..0d5d21dd30bb 100644
>>> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
>>> @@ -88,12 +88,6 @@ properties:
>>> description:
>>> For this device it is strongly suggested to include
>>> arasan,soc-ctl-syscon.
>>> - - items:
>>> - - const: intel,thunderbay-sdhci-5.1 # Intel Thunder Bay eMMC PHY
>>> - - const: arasan,sdhci-5.1
>>
>> Instead should be made rather deprecated, unless you are sure there is
>> no single person in the world using the bindings (e.g. with BSD or
>> bootloader)?
>
> I am sorry but this is not clear to me. As I understand it,
> the hardware was never released, so the binding serves no
> purpose. Should it be removed or "deprecated"?
Hm, commit msg said cancelled and I understood that it was released and
then got cancelled. But indeed maybe just remove it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-09 15:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 5:44 [PATCH v1 1/4] Revert "mmc: sdhci-of-arasan: Add intel Thunder Bay SOC support to the arasan eMMC driver" rashmi.a
2023-01-24 5:44 ` [PATCH v1 2/4] Revert "dt-bindings: mmc: Add bindings for Intel Thunder Bay SoC" rashmi.a
2023-01-24 11:31 ` Krzysztof Kozlowski
2023-03-09 6:43 ` A, Rashmi
2023-03-09 6:48 ` Krzysztof Kozlowski
2023-03-09 14:12 ` Adrian Hunter
2023-03-09 14:57 ` Krzysztof Kozlowski [this message]
2023-01-24 5:44 ` [PATCH v1 3/4] Revert "phy: intel: Add Thunder Bay eMMC PHY support" rashmi.a
2023-01-24 11:59 ` Vinod Koul
2023-01-24 5:44 ` [PATCH v1 4/4] Revert "dt-bindings: phy: intel: Add Thunder Bay eMMC PHY bindings" rashmi.a
2023-01-25 19:58 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50c2b5de-4aed-ebd5-86e9-55813e740869@kernel.org \
--to=krzk@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=furong.zhou@intel.com \
--cc=kenchappa.demakkanavar@intel.com \
--cc=kishon@ti.com \
--cc=kris.pan@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mahesh.r.vaidya@intel.com \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mgross@linux.intel.com \
--cc=michal.simek@xilinx.com \
--cc=nandhini.srikandan@intel.com \
--cc=rashmi.a@intel.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vasavi.v.itha@intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox