From: Shreenidhi Shedi <yesshedi@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: gregkh@linuxfoundation.org, dwmw2@infradead.org,
linux-kernel@vger.kernel.org, sshedi@vmware.com
Subject: Re: [PATCH v5 1/7] sign-file: refactor argument parsing logic - 1
Date: Wed, 22 Mar 2023 01:20:24 +0530 [thread overview]
Message-ID: <50ead5e9-27ab-39f8-2319-ae7695957e87@gmail.com> (raw)
In-Reply-To: <2051795.1679382250@warthog.procyon.org.uk>
On Tue, 21-Mar-2023 12:34, David Howells wrote:
> Shreenidhi Shedi <yesshedi@gmail.com> wrote:
>
>> - Use getopt_long_only for parsing input args
>
> To Greg's point, this should probably be the subject line of this patch. In
> the body you need to explain why/what the point is, which:
>
>> - Use more easy to remember command line argument names
>
> might be part of.
>
> David
>
Hi Greg & David,
Thanks for your time and patience. I have tried addressing your concerns
in v6, hoping that I have got it right this time :)
--
Shedi
next prev parent reply other threads:[~2023-03-21 19:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 18:43 [PATCH v5 0/7] refactor file signing program Shreenidhi Shedi
2023-03-20 18:43 ` [PATCH v5 1/7] sign-file: refactor argument parsing logic - 1 Shreenidhi Shedi
2023-03-21 7:04 ` David Howells
2023-03-21 19:50 ` Shreenidhi Shedi [this message]
2023-03-20 18:43 ` [PATCH v5 2/7] sign-file: refactor argument parsing logic - 2 Shreenidhi Shedi
2023-03-20 18:43 ` [PATCH v5 3/7] sign-file: refactor argument parsing logic - 3 Shreenidhi Shedi
2023-03-20 18:43 ` [PATCH v5 4/7] sign-file: add support to sign modules in bulk Shreenidhi Shedi
2023-03-20 18:43 ` [PATCH v5 5/7] sign-file: improve help message Shreenidhi Shedi
2023-03-20 18:43 ` [PATCH v5 6/7] sign-file: use const with a global string constant Shreenidhi Shedi
2023-03-20 18:43 ` [PATCH v5 7/7] sign-file: fix do while styling issue Shreenidhi Shedi
2023-03-20 18:49 ` [PATCH v5 0/7] refactor file signing program Shreenidhi Shedi
2023-03-21 7:00 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2023-03-20 17:57 [PATCH v5 1/7] sign-file: refactor argument parsing logic - 1 Shreenidhi Shedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ead5e9-27ab-39f8-2319-ae7695957e87@gmail.com \
--to=yesshedi@gmail.com \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshedi@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox