public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Nuno Sá" <noname.nuno@gmail.com>
To: Kriish Sharma <kriish.sharma2006@gmail.com>,
	nuno.sa@analog.com,  olivier.moysan@foss.st.com,
	jic23@kernel.org, dlechner@baylibre.com,  andy@kernel.org
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel test robot	 <lkp@intel.com>
Subject: Re: [PATCH v3] iio: backend: fix kernel-doc to avoid warnings and ensure consistency
Date: Tue, 28 Oct 2025 11:56:58 +0000	[thread overview]
Message-ID: <50f7ef82a98b2d2860466b85f172bcec36fd046b.camel@gmail.com> (raw)
In-Reply-To: <20251028093326.1087660-1-kriish.sharma2006@gmail.com>

On Tue, 2025-10-28 at 09:33 +0000, Kriish Sharma wrote:
> Fix multiple kernel-doc warnings and make the documentation style
> consistent in drivers/iio/industrialio-backend.c.
> 
> Changes include:
>  - Add missing @chan parameter description in
>    iio_backend_oversampling_ratio_set().
>  - Add missing RETURNS section in iio_backend_get_priv().
>  - Replace Return: with “RETURNS:” across the file for consistency.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202506292344.HLJbrrgR-lkp@intel.com
> Suggested-by: Andy Shevchenko <andy@kernel.org>
> Suggested-by: David Lechner <dlechner@baylibre.com>
> Signed-off-by: Kriish Sharma <kriish.sharma2006@gmail.com>
> ---

Thanks for this!

Reviewed-by: Nuno Sá <nuno.sa@analog.com>

> v3:
>  - Changed Return: to RETURNS: for consistency across the file as
>    suggested by David
> 
> v2:
> https://lore.kernel.org/all/20251027092159.918445-1-kriish.sharma2006@gmail.com
> 
> v1:
> https://lore.kernel.org/all/20251025102008.253566-1-kriish.sharma2006@gmail.com
> 
>  drivers/iio/industrialio-backend.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/industrialio-backend.c b/drivers/iio/industrialio-
> backend.c
> index 23760652a046..447b694d6d5f 100644
> --- a/drivers/iio/industrialio-backend.c
> +++ b/drivers/iio/industrialio-backend.c
> @@ -702,7 +702,7 @@ EXPORT_SYMBOL_NS_GPL(iio_backend_interface_type_get,
> "IIO_BACKEND");
>   * interface/data bus. Hence, the backend device needs to be aware of it so
>   * data can be correctly transferred.
>   *
> - * Return:
> + * RETURNS:
>   * 0 on success, negative error number on failure.
>   */
>  int iio_backend_data_size_set(struct iio_backend *back, unsigned int size)
> @@ -717,9 +717,10 @@ EXPORT_SYMBOL_NS_GPL(iio_backend_data_size_set,
> "IIO_BACKEND");
>  /**
>   * iio_backend_oversampling_ratio_set - set the oversampling ratio
>   * @back: Backend device
> + * @chan: Channel number
>   * @ratio: The oversampling ratio - value 1 corresponds to no oversampling.
>   *
> - * Return:
> + * RETURNS:
>   * 0 on success, negative error number on failure.
>   */
>  int iio_backend_oversampling_ratio_set(struct iio_backend *back,
> @@ -1064,6 +1065,9 @@
> EXPORT_SYMBOL_NS_GPL(__devm_iio_backend_get_from_fwnode_lookup,
> "IIO_BACKEND");
>  /**
>   * iio_backend_get_priv - Get driver private data
>   * @back: Backend device
> + *
> + * RETURNS:
> + * Pointer to the driver private data associated with the backend.
>   */
>  void *iio_backend_get_priv(const struct iio_backend *back)
>  {

      parent reply	other threads:[~2025-10-28 11:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-28  9:33 [PATCH v3] iio: backend: fix kernel-doc to avoid warnings and ensure consistency Kriish Sharma
2025-10-28 10:12 ` Andy Shevchenko
2025-11-02 11:56   ` Jonathan Cameron
2025-10-28 11:56 ` Nuno Sá [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50f7ef82a98b2d2860466b85f172bcec36fd046b.camel@gmail.com \
    --to=noname.nuno@gmail.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=kriish.sharma2006@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=nuno.sa@analog.com \
    --cc=olivier.moysan@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox