From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752580Ab3AWXi4 (ORCPT ); Wed, 23 Jan 2013 18:38:56 -0500 Received: from casper.infradead.org ([85.118.1.10]:37469 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751143Ab3AWXiv (ORCPT ); Wed, 23 Jan 2013 18:38:51 -0500 Message-ID: <510074C7.6090203@infradead.org> Date: Wed, 23 Jan 2013 15:39:51 -0800 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 MIME-Version: 1.0 To: Yijing Wang CC: Rob Landley , Bjorn Helgaas , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Jon Mason , linux-pci@vger.kernel.org, Andrew Murray , Hanjun Guo , jiang.liu@huawei.com Subject: Re: [Update][PATCH] PCI: Document PCIE BUS MPS parameters References: <1358944092-28884-1-git-send-email-wangyijing@huawei.com> In-Reply-To: <1358944092-28884-1-git-send-email-wangyijing@huawei.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/23/13 04:28, Yijing Wang wrote: > Document PCIE BUS MPS parameters pcie_bus_tune_off, pcie_bus_safe, > pcie_bus_peer2peer, pcie_bus_perf into Documentation/kernel-parameters.txt. > These parameters were introduced by Jon Mason at > commit 5f39e6705 and commit b03e7495a8. Document these into > kernel-parameters.txt can help users to understand and use the parameters. > > Signed-off-by: Yijing Wang > --- > Documentation/kernel-parameters.txt | 15 +++++++++++++++ > 1 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt > index 363e348..1fb269b 100644 > --- a/Documentation/kernel-parameters.txt > +++ b/Documentation/kernel-parameters.txt > @@ -2227,6 +2227,21 @@ bytes respectively. Such letter suffixes can also be entirely omitted. > This sorting is done to get a device > order compatible with older (<= 2.4) kernels. > nobfsort Don't sort PCI devices into breadth-first order. > + pcie_bus_tune_off Disable PCI-E MPS turning and using > + the BIOS configured MPS defaults. BIOS-configured > + pcie_bus_safe Use the smallest common denominator MPS > + of the entire tree below a root complex for every device > + on that fabric. Can avoid inconsistent mps problem caused s/mps/MPS/ i.e., use "MPS" consistently. > + by hotplug. > + pcie_bus_perf Configure pcie device MPS to the largest allowable > + MPS based on its parent bus. And also set MRRS to the "And also" is redundant. Just say Also. What is (are) MRRS? > + largest supported value but cannot be configured larger > + than the MPS the device or the bus can support for Max > + performance. > + pcie_bus_peer2peer Make the system wide MPS the smallest system-wide > + possible value (128B).This configuration could prevent it ^ Space before "This" > + from working by having the MPS on one root port different > + than the MPS on another. > cbiosize=nn[KMG] The fixed amount of bus space which is > reserved for the CardBus bridge's IO window. > The default value is 256 bytes. > -- ~Randy