Re: [PATCH v2 2/6] sched: split out css_online/css_offline from tg creation/destruction

Li Zefan
2013-01-25T01:38:49Z

On 2013/1/24 18:04, Ingo Molnar wrote:
>
> * Li Zefan <lizefan@huawei.com> wrote:
>
>> extern struct task_group *sched_create_group(struct task_group *parent);
>> +extern void sched_online_group(struct task_group *tg,
>> + struct task_group *parent);
>> extern void sched_destroy_group(struct task_group *tg);
>> +extern void sched_offline_group(struct task_group *tg);
>
> Btw., a rename of these APIs might be in order, along the usual
> patterns:
>
> sched_task_group_create()
> sched_task_group_online()
> sched_task_group_offline()
> sched_task_group_destroy()
>
> etc.
>
> that way the naming is more hierarchical and there's no clash
> with the sched_group concept which is about something else.
>
> (In a separate patch.)
>

Agreed. I'll send a cleanup patch to you when those patches hit mainline.
(That will be 3.9-rc1 or later)