From: Alex Shi <alex.shi@intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de,
akpm@linux-foundation.org, arjan@linux.intel.com, bp@alien8.de,
pjt@google.com, namhyung@kernel.org, efault@gmx.de,
vincent.guittot@linaro.org, gregkh@linuxfoundation.org,
preeti@linux.vnet.ibm.com, viresh.kumar@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task
Date: Thu, 24 Jan 2013 23:16:41 +0800 [thread overview]
Message-ID: <51015059.8010505@intel.com> (raw)
In-Reply-To: <20130124100823.GE26351@gmail.com>
On 01/24/2013 06:08 PM, Ingo Molnar wrote:
>
> * Alex Shi <alex.shi@intel.com> wrote:
>
>> @@ -2539,7 +2539,11 @@ static void __update_cpu_load(struct rq *this_rq, unsigned long this_load,
>> void update_idle_cpu_load(struct rq *this_rq)
>> {
>> unsigned long curr_jiffies = ACCESS_ONCE(jiffies);
>> +#if defined(CONFIG_SMP) && defined(CONFIG_FAIR_GROUP_SCHED)
>> + unsigned long load = (unsigned long)this_rq->cfs.runnable_load_avg;
>> +#else
>> unsigned long load = this_rq->load.weight;
>> +#endif
>
> I'd not make it conditional - just calculate runnable_load_avg
> all the time (even if group scheduling is disabled) and use it
> consistently. The last thing we want is to bifurcate scheduler
> balancer behavior even further.
Very glad to see you being back, Ingo! :)
This patch set is following my power aware scheduling patchset. But for
a separate workable runnable load engaged balancing. only needs the
other 3 patches, that already sent you at another patchset
[patch v4 06/18] sched: give initial value for runnable avg of sched
[patch v4 07/18] sched: set initial load avg of new forked task
[patch v4 08/18] Revert "sched: Introduce temporary FAIR_GROUP_SCHED
>
> Thanks,
>
> Ingo
>
--
Thanks
Alex
next prev parent reply other threads:[~2013-01-24 15:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 3:30 [ RFC patch 0/4]: use runnable load avg in cfs balance instead of instant load Alex Shi
2013-01-24 3:30 ` [PATCH 1/4] sched: update cpu load after task_tick Alex Shi
2013-01-24 3:30 ` [PATCH 2/4] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task Alex Shi
2013-01-24 10:08 ` Ingo Molnar
2013-01-24 15:16 ` Alex Shi [this message]
2013-01-25 1:03 ` Alex Shi
2013-01-24 3:30 ` [PATCH 3/4] sched: consider runnable load average in move_tasks Alex Shi
2013-01-24 3:30 ` [PATCH 4/4] sched: consider runnable load average in effective_load Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51015059.8010505@intel.com \
--to=alex.shi@intel.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=bp@alien8.de \
--cc=efault@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=preeti@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox