From: Michal Marek <mmarek@suse.cz>
To: David Howells <dhowells@redhat.com>
Cc: rusty@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] MODSIGN: Specify the hash algorithm on sign-file command line
Date: Thu, 24 Jan 2013 20:59:00 +0100 [thread overview]
Message-ID: <51019284.4070900@suse.cz> (raw)
In-Reply-To: <28722.1359040632@warthog.procyon.org.uk>
Dne 24.1.2013 16:17, David Howells napsal(a):
> Michal Marek <mmarek@suse.cz> wrote:
>
>> +our ($opt_v, $opt_a);
>
> Should this be 'our' or 'my'?
These are global variables set by getopts(), so they need to be declared
'our'. But I can change it to use the two-argument version of getopts,
that does not use global variables.
Michal
next prev parent reply other threads:[~2013-01-24 19:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 15:30 [PATCH 0/4] MODSIGN: Allow to sign modules outside build Michal Marek
2013-01-23 15:30 ` [PATCH 1/4] MODSIGN: Simplify Makefile with a Kconfig helper Michal Marek
2013-01-24 15:11 ` David Howells
2013-01-23 15:30 ` [PATCH 2/4] MODSIGN: Specify the hash algorithm on sign-file command line Michal Marek
2013-01-24 15:16 ` David Howells
2013-01-24 15:17 ` David Howells
2013-01-24 19:59 ` Michal Marek [this message]
2013-01-25 0:07 ` David Howells
2013-01-23 15:30 ` [PATCH 3/4] MODSIGN: Add -s <signature> option to sign-file Michal Marek
2013-01-24 15:20 ` David Howells
2013-01-23 15:30 ` [PATCH 4/4] MODSIGN: Add option to not sign modules during modules_install Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51019284.4070900@suse.cz \
--to=mmarek@suse.cz \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox