* [tip:x86/cpu] x86/process: Change %8s to %s for pr_warn() in release_thread()
@ 2013-01-24 20:45 tip-bot for Chen Gang
2013-01-25 2:50 ` Chen Gang
0 siblings, 1 reply; 2+ messages in thread
From: tip-bot for Chen Gang @ 2013-01-24 20:45 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, gang.chen, tglx
Commit-ID: 349eab6eb07794c59e37703ccbfeb5920721885c
Gitweb: http://git.kernel.org/tip/349eab6eb07794c59e37703ccbfeb5920721885c
Author: Chen Gang <gang.chen@asianux.com>
AuthorDate: Tue, 6 Nov 2012 14:45:46 +0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 24 Jan 2013 18:11:03 +0100
x86/process: Change %8s to %s for pr_warn() in release_thread()
the length of dead_task->comm[] is 16 (TASK_COMM_LEN)
on pr_warn(), it is not meaningful to use %8s for task->comm[].
So change it to %s, since the line is not solid anyway.
Additional information:
%8s limit the width, not for the original string output length
if name length is more than 8, it still can be fully displayed.
if name length is less than 8, the ' ' will be filled before name.
%.8s truly limit the original string output length (precision)
Signed-off-by: Chen Gang <gang.chen@asianux.com>
Link: http://lkml.kernel.org/n/tip-nridm1zvreai1tgfLjuexDmd@git.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/process_64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c
index 6e68a61..0f49677 100644
--- a/arch/x86/kernel/process_64.c
+++ b/arch/x86/kernel/process_64.c
@@ -117,7 +117,7 @@ void release_thread(struct task_struct *dead_task)
{
if (dead_task->mm) {
if (dead_task->mm->context.size) {
- pr_warn("WARNING: dead process %8s still has LDT? <%p/%d>\n",
+ pr_warn("WARNING: dead process %s still has LDT? <%p/%d>\n",
dead_task->comm,
dead_task->mm->context.ldt,
dead_task->mm->context.size);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [tip:x86/cpu] x86/process: Change %8s to %s for pr_warn() in release_thread()
2013-01-24 20:45 [tip:x86/cpu] x86/process: Change %8s to %s for pr_warn() in release_thread() tip-bot for Chen Gang
@ 2013-01-25 2:50 ` Chen Gang
0 siblings, 0 replies; 2+ messages in thread
From: Chen Gang @ 2013-01-25 2:50 UTC (permalink / raw)
To: mingo, hpa, linux-kernel, gang.chen, tglx; +Cc: linux-tip-commits
于 2013年01月25日 04:45, tip-bot for Chen Gang 写道:
> Commit-ID: 349eab6eb07794c59e37703ccbfeb5920721885c
> Gitweb: http://git.kernel.org/tip/349eab6eb07794c59e37703ccbfeb5920721885c
> Author: Chen Gang <gang.chen@asianux.com>
> AuthorDate: Tue, 6 Nov 2012 14:45:46 +0800
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Thu, 24 Jan 2013 18:11:03 +0100
>
thank you very much.
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-25 2:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-24 20:45 [tip:x86/cpu] x86/process: Change %8s to %s for pr_warn() in release_thread() tip-bot for Chen Gang
2013-01-25 2:50 ` Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox