Re: [PATCH 06/13] sg_io: whitelist a few more commands for multimedia devices

Paolo Bonzini
2013-01-25T17:16:22Z

Il 25/01/2013 18:04, Tejun Heo ha scritto:
>> >
>> > I think it's the other way round. What's the justification for leaving
>> > them out, if they are in the standard? Since we're touching the
>> > commands for other standards, it's better to be complete for MMC as well.
> Maybe my experience with ATA left me bitter with the standards, but
> opening gate to everything described in standard sounds like a pretty
> bad idea to me. If there are users and devices which make use of them
> in sane way, sure. If not, what's the point of risking it?

Well, you can find broken devices for pretty much every command in the
list. Anyhow, the other two commands are obsolete so I'm okay with
leaving them out, if only for the sake of avoiding useless email threads.

Paolo

>> > At least one of them (MECHANISM STATUS) is implemented in both QEMU and
>> > Bochs, so someone is using it. If that someone were run virtualized,
>> > with the host /dev/sr0 passed directly to the guest rather than
>> > emulated, it would break.
> Sure, then, enable MECHANISM_STATUS.