From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Florian Vaussard <florian.vaussard@epfl.ch>
Cc: Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
Thierry Reding <thierry.reding@avionic-design.de>,
<linux-leds@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] pwm: Add can_sleep property to drivers
Date: Fri, 25 Jan 2013 14:51:30 +0100 [thread overview]
Message-ID: <51028DE2.1050904@ti.com> (raw)
In-Reply-To: <1359121471-21457-3-git-send-email-florian.vaussard@epfl.ch>
On 01/25/2013 02:44 PM, Florian Vaussard wrote:
> Calls to PWM drivers connected through I2C can sleep.
> Use the new can_sleep property.
>
> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/pwm/pwm-twl-led.c | 1 +
> drivers/pwm/pwm-twl.c | 1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/pwm/pwm-twl-led.c b/drivers/pwm/pwm-twl-led.c
> index 9dfa0f3..6261193 100644
> --- a/drivers/pwm/pwm-twl-led.c
> +++ b/drivers/pwm/pwm-twl-led.c
> @@ -300,6 +300,7 @@ static int twl_pwmled_probe(struct platform_device *pdev)
>
> twl->chip.dev = &pdev->dev;
> twl->chip.base = -1;
> + twl->chip.can_sleep = 1;
>
> mutex_init(&twl->mutex);
>
> diff --git a/drivers/pwm/pwm-twl.c b/drivers/pwm/pwm-twl.c
> index e65db95..4e56cd8 100644
> --- a/drivers/pwm/pwm-twl.c
> +++ b/drivers/pwm/pwm-twl.c
> @@ -315,6 +315,7 @@ static int twl_pwm_probe(struct platform_device *pdev)
> twl->chip.dev = &pdev->dev;
> twl->chip.base = -1;
> twl->chip.npwm = 2;
> + twl->chip.can_sleep = 1;
>
> mutex_init(&twl->mutex);
>
>
--
Péter
next prev parent reply other threads:[~2013-01-25 13:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 13:44 [PATCH v2 0/3] leds-pwm: Defer PWM calls if PWM can sleep Florian Vaussard
2013-01-25 13:44 ` [PATCH v2 1/3] pwm: Add pwm_cansleep() as exported API to users Florian Vaussard
2013-01-25 13:51 ` Peter Ujfalusi
2013-01-26 5:40 ` Thierry Reding
2013-01-28 8:45 ` Peter Ujfalusi
2013-01-28 9:36 ` Florian Vaussard
2013-01-28 9:57 ` Thierry Reding
2013-01-28 10:57 ` Florian Vaussard
2013-01-28 13:16 ` Thierry Reding
2013-01-28 15:01 ` Russell King - ARM Linux
2013-01-28 15:46 ` Florian Vaussard
2013-01-25 13:44 ` [PATCH v2 2/3] pwm: Add can_sleep property to drivers Florian Vaussard
2013-01-25 13:51 ` Peter Ujfalusi [this message]
2013-01-25 13:44 ` [PATCH v2 3/3] leds: leds-pwm: Defer led_pwm_set() if PWM can sleep Florian Vaussard
2013-01-25 13:52 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51028DE2.1050904@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=cooloney@gmail.com \
--cc=florian.vaussard@epfl.ch \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox