public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
	konrad.wilk@oracle.com, torvalds@linux-foundation.org,
	JBeulich@suse.com, tglx@linutronix.de,
	linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/asm] x86/xor: Make virtualization friendly
Date: Fri, 25 Jan 2013 14:15:20 -0800	[thread overview]
Message-ID: <510303F8.1080105@zytor.com> (raw)
In-Reply-To: <510302FD.3090009@zytor.com>

On 01/25/2013 02:11 PM, H. Peter Anvin wrote:
> On 01/25/2013 02:43 AM, tip-bot for Jan Beulich wrote:
>> Commit-ID:  05fbf4d6fc6a3c0c3e63b77979c9311596716d10
>> Gitweb:     http://git.kernel.org/tip/05fbf4d6fc6a3c0c3e63b77979c9311596716d10
>> Author:     Jan Beulich <JBeulich@suse.com>
>> AuthorDate: Fri, 2 Nov 2012 14:21:23 +0000
>> Committer:  Ingo Molnar <mingo@kernel.org>
>> CommitDate: Fri, 25 Jan 2013 09:23:51 +0100
>>
>> x86/xor: Make virtualization friendly
>>
>> In virtualized environments, the CR0.TS management needed here
>> can be a lot slower than anticipated by the original authors of
>> this code, which particularly means that in such cases forcing
>> the use of SSE- (or MMX-) based implementations is not desirable
>> - actual measurements should always be done in that case.
>>
>> For consistency, pull into the shared (32- and 64-bit) header
>> not only the inclusion of the generic code, but also that of the
>> AVX variants.
>>
> 
> This patch is wrong and should be dropped.  I verified it with the KVM
> people that they do NOT want this change.  It is a Xen-specific problem.
> 

FWIW: I have dropped this patch from tip:x86/asm.

	-hpa



  reply	other threads:[~2013-01-25 22:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-02 14:21 [PATCH 3/3, v2] x86/xor: make virtualization friendly Jan Beulich
2012-11-02 17:30 ` H. Peter Anvin
2012-11-05  9:10   ` Jan Beulich
2013-01-25 10:43 ` [tip:x86/asm] x86/xor: Make " tip-bot for Jan Beulich
2013-01-25 22:11   ` H. Peter Anvin
2013-01-25 22:15     ` H. Peter Anvin [this message]
2013-01-26  1:05       ` H. Peter Anvin
2013-01-26 16:49         ` KY Srinivasan
2013-01-26 12:10       ` Ingo Molnar
2013-01-28  9:04     ` Jan Beulich
2013-01-28 15:26       ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=510303F8.1080105@zytor.com \
    --to=hpa@zytor.com \
    --cc=JBeulich@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox