From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: <linux-arch@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<arnd@arndb.de>
Subject: Re: [PATCH v3 02/71] ARC: Build system: Makefiles, Kconfig, Linker script
Date: Tue, 29 Jan 2013 19:15:07 +0530 [thread overview]
Message-ID: <5107D263.4090606@synopsys.com> (raw)
In-Reply-To: <20130128184419.GA24853@merkur.ravnborg.org>
On Tuesday 29 January 2013 12:14 AM, Sam Ravnborg wrote:
> On Mon, Jan 28, 2013 at 11:59:36AM +0530, Vineet Gupta wrote:
>> Hi Sam,
>>
>> On Thursday 24 January 2013 04:20 PM, Vineet Gupta wrote:
>>> Arnd in his review pointed out that arch Kconfig organisation has several
>>> deficiencies:
>>>
>>> * Build time entries for things which can be runtime extracted from DT
>>> (e.g. SDRAM size, core clk frequency..)
>>> * Not multi-platform-image-build friendly (choice .. endchoice constructs)
>>> * cpu variants support (750/770) is exclusive.
>>>
>>> The first 2 have been fixed in subsequent patches.
>>> Due to the nature of the 750 and 770, it is not possible to build for
>>> both together, w/o special runtime glue code which would hurt
>>> performance.
>>>
>>> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
>>> Cc: Arnd Bergmann <arnd@arndb.de>
>>> Cc: Sam Ravnborg <sam@ravnborg.org>
> Looks good - all former comments addressed, and nothing were jumping
> into my eyes now.
> Many existing architectures looks worse from the build stuff perspective...
>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> Sam
Thx Sam. I have a following one liner change to the version you reviewed. Will it
be OK to add your ACK despite that or do I need to send the updated patch for you
to take a look again.
-Vineet
------------------------->8-----------------------
diff --git a/arch/arc/plat-arcfpga/Kconfig b/arch/arc/plat-arcfpga/Kconfig
index 3fecd6f..b41e786 100644
--- a/arch/arc/plat-arcfpga/Kconfig
+++ b/arch/arc/plat-arcfpga/Kconfig
@@ -8,6 +8,7 @@
menuconfig ARC_PLAT_FPGA_LEGACY
bool "\"Legacy\" ARC FPGA dev Boards"
+ select ISS_SMP_EXTN if SMP
help
Support for ARC development boards, provided by Synopsys.
These are based on FPGA or ISS. e.g.
@@ -19,7 +20,6 @@ if ARC_PLAT_FPGA_LEGACY
config ARC_BOARD_ANGEL4
bool "ARC Angel4"
- select ISS_SMP_EXTN if SMP
default y
help
ARC Angel4 FPGA Ref Platform (Xilinx Virtex Based)
------------------------->8-----------------------
next prev parent reply other threads:[~2013-01-29 13:45 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 10:50 [PATCH v3 00/71] Synopsys ARC Linux kernel Port (Part #1) Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 01/71] ARC: Generic Headers Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 02/71] ARC: Build system: Makefiles, Kconfig, Linker script Vineet Gupta
2013-01-28 6:29 ` Vineet Gupta
2013-01-28 18:44 ` Sam Ravnborg
2013-01-29 13:45 ` Vineet Gupta [this message]
2013-01-29 17:52 ` Sam Ravnborg
2013-02-11 11:29 ` James Hogan
2013-02-11 11:44 ` Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 06/71] ARC: uaccess friends Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 11/71] ARC: Fundamental ARCH data-types/defines Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 17/71] ARC: Syscall support (no-legacy-syscall ABI) Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 18/71] ARC: Process-creation/scheduling/idle-loop Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 19/71] ARC: Timers/counters/delay management Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 20/71] ARC: Signal handling Vineet Gupta
2013-02-11 7:26 ` pt_regs leak into userspace (was Re: [PATCH v3 20/71] ARC: Signal handling) Vineet Gupta
2013-02-11 9:36 ` Jonas Bonn
2013-02-11 10:13 ` Vineet Gupta
2013-02-11 10:28 ` James Hogan
2013-02-11 10:53 ` Jonas Bonn
2013-02-11 10:57 ` James Hogan
2013-02-11 11:01 ` James Hogan
2013-02-11 11:22 ` Vineet Gupta
2013-02-11 12:12 ` Jonas Bonn
2013-02-11 12:37 ` Vineet Gupta
2013-02-11 13:02 ` Jonas Bonn
2013-02-11 13:08 ` Vineet Gupta
2013-02-11 10:30 ` Jonas Bonn
2013-02-11 14:07 ` Al Viro
2013-02-15 7:23 ` Jonas Bonn
2013-02-15 7:35 ` Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 21/71] ARC: [Review] Preparing to fix incorrect syscall restarts due to signals Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 22/71] ARC: [Review] Prevent incorrect syscall restarts Vineet Gupta
2013-01-28 7:42 ` Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 23/71] ARC: Cache Flush Management Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 29/71] ARC: I/O and DMA Mappings Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 30/71] ARC: Boot #1: low-level, setup_arch(), /proc/cpuinfo, mem init Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 32/71] ARC: [DeviceTree] Basic support Vineet Gupta
2013-01-28 7:40 ` Vineet Gupta
2013-01-28 10:21 ` James Hogan
2013-01-29 9:53 ` Vineet Gupta
2013-01-29 10:06 ` James Hogan
2013-01-29 13:25 ` Rob Herring
2013-01-29 13:39 ` Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 33/71] ARC: [DeviceTree] Convert some Kconfig items to runtime values Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 34/71] ARC: [plat-arcfpga]: Enabling DeviceTree for Angel4 board Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 42/71] ARC: Module support Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 44/71] ARC: SMP support Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 48/71] ARC: kprobes support Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 57/71] ARC: Hostlink Pseudo-Driver for Metaware Debugger Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 58/71] ARC: UAPI Disintegrate arch/arc/include/asm Vineet Gupta
2013-01-28 7:36 ` Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 59/71] ARC: Add support for ioremap_prot API Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 62/71] ARC: [Review] Multi-platform image #2: Board callback Infrastructure Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 69/71] ARC: [plat-arcfpga] defconfig for fully loaded ARC Linux Vineet Gupta
2013-01-24 10:50 ` [PATCH v3 70/71] ARC: Provide a default serial.h for uart drivers needing BASE_BAUD Vineet Gupta
2013-01-24 11:01 ` [PATCH v3 45/71] ARC: DWARF2 .debug_frame based stack unwinder Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5107D263.4090606@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).