From: Mugunthan V N <mugunthanvnm@ti.com>
To: Pantelis Antoniou <panto@antoniou-consulting.com>
Cc: Richard Cochran <richardcochran@gmail.com>,
Matt Porter <mporter@ti.com>, Chase Maupin <chase.maupin@ti.com>,
Jason Kridner <jdk@ti.com>, Tony Lindgren <tony@atomide.com>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpsw: Fix interrupt storm among other things
Date: Wed, 30 Jan 2013 14:33:02 +0530 [thread overview]
Message-ID: <5108E1C6.9020201@ti.com> (raw)
In-Reply-To: <3DE2C638-6AE8-4BC9-AD68-3AAA40CD6233@antoniou-consulting.com>
On 1/30/2013 2:06 PM, Pantelis Antoniou wrote:
> Hi Mugunthan,
>
> On Jan 29, 2013, at 1:45 PM, Mugunthan V N wrote:
>
>> On 1/28/2013 6:41 PM, Pantelis Antoniou wrote:
>>> Fix interrupt storm on bone A4 cause by non-by-the-book interrupt handling.
>>> While at it, added a non-NAPI mode (which is easier to debug), plus
>>> some general fixes.
>>>
>>> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
>>> ---
>>> Documentation/devicetree/bindings/net/cpsw.txt | 1 +
>>> drivers/net/ethernet/ti/cpsw.c | 222 +++++++++++++++++++++----
>>> drivers/net/ethernet/ti/davinci_cpdma.c | 4 +-
>>> drivers/net/ethernet/ti/davinci_cpdma.h | 2 +-
>>> include/linux/platform_data/cpsw.h | 1 +
>>> 5 files changed, 194 insertions(+), 36 deletions(-)
>> I have tested CPSW on AM335x EVM 1.5A with flood ping and i am not
>> seeing any interrupt storm.
>> Can you provide more details on how to reproduce the issue.
>>
> A beaglebone prototype with the new silicon version, with the ethernet errata
> fixed displays this. You can't trigger it on old silicon.
>
> The TI people on the CC list can confirm.
But i have the same silicon revision (PG2.0) in my EVM and I am not
seeing any issues. Can you
point me to the ethernet errata which you are mentioning?
Regards
Mugunthan V N
next prev parent reply other threads:[~2013-01-30 9:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 13:11 [PATCH] cpsw: Fix interrupt storm among other things Pantelis Antoniou
2013-01-28 18:24 ` Richard Cochran
2013-01-28 18:40 ` Pantelis Antoniou
2013-01-28 19:49 ` Richard Cochran
2013-01-28 19:56 ` Richard Cochran
2013-01-28 18:27 ` Richard Cochran
2013-01-28 21:14 ` Peter Korsgaard
2013-01-30 8:34 ` Pantelis Antoniou
2013-01-29 11:45 ` Mugunthan V N
2013-01-30 8:36 ` Pantelis Antoniou
2013-01-30 9:03 ` Mugunthan V N [this message]
2013-01-30 9:36 ` Pantelis Antoniou
2013-01-30 10:55 ` Mugunthan V N
2013-01-30 11:08 ` Pantelis Antoniou
2013-01-30 12:38 ` Bedia, Vaibhav
2013-01-30 12:44 ` Pantelis Antoniou
2013-01-30 13:29 ` Bedia, Vaibhav
2013-01-30 13:37 ` Pantelis Antoniou
2013-01-30 13:47 ` Bedia, Vaibhav
2013-01-30 13:51 ` Pantelis Antoniou
2013-01-30 13:53 ` Mugunthan V N
2013-01-30 13:55 ` Pantelis Antoniou
2013-01-30 14:03 ` Mugunthan V N
2013-01-30 19:27 ` Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5108E1C6.9020201@ti.com \
--to=mugunthanvnm@ti.com \
--cc=chase.maupin@ti.com \
--cc=jdk@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mporter@ti.com \
--cc=panto@antoniou-consulting.com \
--cc=richardcochran@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox