From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753603Ab3A3JDe (ORCPT ); Wed, 30 Jan 2013 04:03:34 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:60946 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752180Ab3A3JDa (ORCPT ); Wed, 30 Jan 2013 04:03:30 -0500 Message-ID: <5108E1C6.9020201@ti.com> Date: Wed, 30 Jan 2013 14:33:02 +0530 From: Mugunthan V N User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Pantelis Antoniou CC: Richard Cochran , Matt Porter , Chase Maupin , Jason Kridner , Tony Lindgren , , Subject: Re: [PATCH] cpsw: Fix interrupt storm among other things References: <1359378668-26536-1-git-send-email-panto@antoniou-consulting.com> <5107B650.5090901@ti.com> <3DE2C638-6AE8-4BC9-AD68-3AAA40CD6233@antoniou-consulting.com> In-Reply-To: <3DE2C638-6AE8-4BC9-AD68-3AAA40CD6233@antoniou-consulting.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/30/2013 2:06 PM, Pantelis Antoniou wrote: > Hi Mugunthan, > > On Jan 29, 2013, at 1:45 PM, Mugunthan V N wrote: > >> On 1/28/2013 6:41 PM, Pantelis Antoniou wrote: >>> Fix interrupt storm on bone A4 cause by non-by-the-book interrupt handling. >>> While at it, added a non-NAPI mode (which is easier to debug), plus >>> some general fixes. >>> >>> Signed-off-by: Pantelis Antoniou >>> --- >>> Documentation/devicetree/bindings/net/cpsw.txt | 1 + >>> drivers/net/ethernet/ti/cpsw.c | 222 +++++++++++++++++++++---- >>> drivers/net/ethernet/ti/davinci_cpdma.c | 4 +- >>> drivers/net/ethernet/ti/davinci_cpdma.h | 2 +- >>> include/linux/platform_data/cpsw.h | 1 + >>> 5 files changed, 194 insertions(+), 36 deletions(-) >> I have tested CPSW on AM335x EVM 1.5A with flood ping and i am not >> seeing any interrupt storm. >> Can you provide more details on how to reproduce the issue. >> > A beaglebone prototype with the new silicon version, with the ethernet errata > fixed displays this. You can't trigger it on old silicon. > > The TI people on the CC list can confirm. But i have the same silicon revision (PG2.0) in my EVM and I am not seeing any issues. Can you point me to the ethernet errata which you are mentioning? Regards Mugunthan V N