Re: [PATCH v5 04/18] drm/rockchip: vop2: Fix the windows switch between different layers

Heiko Stuebner
2024-12-10T23:09:24Z

Hi Andy,

Am Montag, 9. Dezember 2024, 13:29:17 CET schrieb Andy Yan:
> From: Andy Yan <andy.yan@rock-chips.com>
>
> Every layer of vop2 should bind a window, and we also need to make
> sure that this window is not used by other layer.
>
> 0x5 is a reserved layer sel value on rk3568, but it will select
> Cluster3 on rk3588, configure unused layers to 0x5 will lead
> alpha blending error on rk3588.
>
> When we bind a window from layerM to layerN, we move the old window
> on layerN to layerM.
>
> Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
> Tested-by: Derek Foreman <derek.foreman@collabora.com>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>

> + /*
> + * Find the win bind to this layer in old state
> + */
> + for (i = 0; i < vop2->data->win_size; i++) {
> + old_win = &vop2->win[i];
> + layer_sel_id = (layer_sel >> (4 * (plane->state->normalized_zpos + ofs))) & 0xf;

checkpatch is unhappy about the length of this line (104 characters).
Could you please restructure it (helper var or line break)
so that it gets below the 100 character mark please?

Thanks a lot
Heiko