From: kishon <kishon@ti.com>
To: Vivek Gautam <gautam.vivek@samsung.com>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>, <linux-samsung-soc@vger.kernel.org>,
<gregkh@linuxfoundation.org>, <balbi@ti.com>
Subject: Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.
Date: Thu, 31 Jan 2013 17:04:23 +0530 [thread overview]
Message-ID: <510A56BF.3040804@ti.com> (raw)
In-Reply-To: <1359631232-7107-1-git-send-email-gautam.vivek@samsung.com>
Hi,
On Thursday 31 January 2013 04:50 PM, Vivek Gautam wrote:
> With device tree support in place for dwc3-core layer,
> it gets PHY from "synopsis-dwc3" node.
> Some controllers may not have separate memory maps and interrupts
> for dwc3 core and platform glue layers. In such case only glue
> layer's node will exist.
Not really. As long as you have dwc3 core as a separate device, you can
add a node for it.
Just that the glue should create a device for dwc3 core using
of_platform_populate.(You can have a look at
drivers/usb/dwc3/dwc3-omap.c in usb-next)
> Moreover, SoCs having multiple dwc3 controllers will have multiple
> PHYs, which eventually be added using usb_add_phy_dev(), and not
> using usb_add_phy(). So each dwc3 controller won't be able to
> get PHYs by simply calling devm_usb_get_phy() also.
No. We have added usb_get_phy_dev() for that purpose in the case of non-dt.
I think, instead you can have a patch to use devm_usb_get_phy_dev() here
and in exynos platform specific code use usb_bind_phy() to bind the phy
and controller till you change it to dt.
> In such cases, dwc3 should expect PHYs from its parent's node.
NAK.
Thanks
Kishon
next prev parent reply other threads:[~2013-01-31 11:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 11:20 [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node Vivek Gautam
2013-01-31 11:34 ` kishon [this message]
2013-01-31 15:23 ` Vivek Gautam
2013-01-31 15:25 ` Felipe Balbi
2013-01-31 15:30 ` Vivek Gautam
2013-01-31 15:38 ` Felipe Balbi
2013-02-01 5:21 ` kishon
2013-02-01 6:22 ` Vivek Gautam
2013-02-01 6:24 ` Vivek Gautam
2013-02-01 8:50 ` Felipe Balbi
2013-02-01 8:53 ` Vivek Gautam
2013-02-01 9:43 ` Felipe Balbi
2013-02-28 14:39 ` Vivek Gautam
2013-03-01 6:41 ` Felipe Balbi
2013-03-04 15:02 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510A56BF.3040804@ti.com \
--to=kishon@ti.com \
--cc=balbi@ti.com \
--cc=gautam.vivek@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox