Re: [RFC 3/4] drm: tegra: use the Common Display Framework

Thierry Reding
2013-01-30T07:24:17Z

[-- Attachment #1: Type: text/plain, Size: 968 bytes --]

On Wed, Jan 30, 2013 at 04:01:48PM +0900, Alex Courbot wrote:
> On 01/30/2013 03:50 PM, Mark Zhang wrote:
> >>@@ -147,6 +148,9 @@ struct tegra_output {
> >>
> >> struct drm_encoder encoder;
> >> struct drm_connector connector;
> >>+ struct display_entity this;
> >>+ struct display_entity *output;
> >
> >Could you pick up a somewhat meaningful name? You know, there are too
> >many variables with name "drm/connector/output/encoder"... :)
>
> Well, it's supposed to be abstract. From the CDF point of view it
> could be anything besides a panel. I know this makes it an output of
> an output, but I can't think of anything better right now.

How about renaming "this" to stream to match with what the output is in
CDF speak. And the output's output is the panel, right? Why not just
call it that? Even if it isn't directly connected to a panel entity but
has indeed a whole pipeline in between, for tegra-drm it is still a
panel.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]