* Re: kernel/cgroup_freezer.c:151:3: error: 'system_freezing_cnt' undeclared
[not found] <510aa746.fVU8ZdQ2hys/RwjS%fengguang.wu@intel.com>
@ 2013-01-31 23:14 ` Tejun Heo
2013-02-01 0:46 ` Chris Metcalf
0 siblings, 1 reply; 5+ messages in thread
From: Tejun Heo @ 2013-01-31 23:14 UTC (permalink / raw)
To: Chris Metcalf, Rafael J. Wysocki; +Cc: kbuild test robot, linux-kernel
Hello, guys.
On Fri, Feb 01, 2013 at 01:17:58AM +0800, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux master
> head: 04c2eee5b9dfcb13f3cd07a5537fb8c785f2751a
> commit: a3201227f803ad7fd43180c5195dbe5a2bf998aa freezer: make freezing() test freeze conditions in effect instead of TIF_FREEZE
> date: 1 year, 2 months ago
Heh, this gone goes way back.
> config: make ARCH=tile allyesconfig
>
> All error/warnings:
>
> kernel/cgroup_freezer.c: In function 'freezer_destroy':
> >> kernel/cgroup_freezer.c:151:3: error: 'system_freezing_cnt' undeclared (first use in this function)
> kernel/cgroup_freezer.c:151:3: note: each undeclared identifier is reported only once for each function it appears in
> kernel/cgroup_freezer.c: In function 'freezer_fork':
> kernel/cgroup_freezer.c:209:3: error: implicit declaration of function 'freeze_task'
> kernel/cgroup_freezer.c: In function 'unfreeze_cgroup':
> kernel/cgroup_freezer.c:296:3: error: implicit declaration of function '__thaw_task'
> kernel/cgroup_freezer.c: In function 'freezer_change_state':
> >> kernel/cgroup_freezer.c:315:4: error: 'system_freezing_cnt' undeclared (first use in this function)
So, CONFIG_FREEZER is defbool which is turned on automatically if
CONFIG_CGROUP_FREEZER; however, CONFIG_FREEZER is defined in
Kconfig.freezer which should be included by arch Kconfig file. tile
doesn't include it (maybe it doesn't want freezer for some reason?).
CONFIG_COGRUP_FREEZER is in init/Kconfig, so allyesconfig enables it
but as CONFIG_FREEZER definition isn't visible, we end up with broken
config CONFIG_CGROUP_FREEZER && !CONFIG_FREEZER.
Maybe we need to move CONFIG_CGROUP_FREEZER to Kconfig.freezer if tile
actually doesn't want freezer?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: kernel/cgroup_freezer.c:151:3: error: 'system_freezing_cnt' undeclared
2013-01-31 23:14 ` kernel/cgroup_freezer.c:151:3: error: 'system_freezing_cnt' undeclared Tejun Heo
@ 2013-02-01 0:46 ` Chris Metcalf
2013-02-01 0:52 ` Tejun Heo
0 siblings, 1 reply; 5+ messages in thread
From: Chris Metcalf @ 2013-02-01 0:46 UTC (permalink / raw)
To: Tejun Heo; +Cc: Rafael J. Wysocki, kbuild test robot, linux-kernel
On 1/31/2013 6:14 PM, Tejun Heo wrote:
> Hello, guys.
>
> On Fri, Feb 01, 2013 at 01:17:58AM +0800, kbuild test robot wrote:
>> tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux master
>> head: 04c2eee5b9dfcb13f3cd07a5537fb8c785f2751a
>> commit: a3201227f803ad7fd43180c5195dbe5a2bf998aa freezer: make freezing() test freeze conditions in effect instead of TIF_FREEZE
>> date: 1 year, 2 months ago
> Heh, this gone goes way back.
>
>> config: make ARCH=tile allyesconfig
>>
>> All error/warnings:
>>
>> kernel/cgroup_freezer.c: In function 'freezer_destroy':
>>>> kernel/cgroup_freezer.c:151:3: error: 'system_freezing_cnt' undeclared (first use in this function)
>> kernel/cgroup_freezer.c:151:3: note: each undeclared identifier is reported only once for each function it appears in
>> kernel/cgroup_freezer.c: In function 'freezer_fork':
>> kernel/cgroup_freezer.c:209:3: error: implicit declaration of function 'freeze_task'
>> kernel/cgroup_freezer.c: In function 'unfreeze_cgroup':
>> kernel/cgroup_freezer.c:296:3: error: implicit declaration of function '__thaw_task'
>> kernel/cgroup_freezer.c: In function 'freezer_change_state':
>>>> kernel/cgroup_freezer.c:315:4: error: 'system_freezing_cnt' undeclared (first use in this function)
> So, CONFIG_FREEZER is defbool which is turned on automatically if
> CONFIG_CGROUP_FREEZER; however, CONFIG_FREEZER is defined in
> Kconfig.freezer which should be included by arch Kconfig file. tile
> doesn't include it (maybe it doesn't want freezer for some reason?).
We have never had a customer ask for suspend-to-RAM or other similar modes. As far as I know no one has looked into FREEZER or SUSPEND. That said, there's no particular reason not to just try it and see if it works.
> CONFIG_COGRUP_FREEZER is in init/Kconfig, so allyesconfig enables it
> but as CONFIG_FREEZER definition isn't visible, we end up with broken
> config CONFIG_CGROUP_FREEZER && !CONFIG_FREEZER.
>
> Maybe we need to move CONFIG_CGROUP_FREEZER to Kconfig.freezer if tile
> actually doesn't want freezer?
That seems reasonable to me, but I'm happy to experiment with including Kconfig.freezer from the arch/tile/Kconfig if that feels like a better solution.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: kernel/cgroup_freezer.c:151:3: error: 'system_freezing_cnt' undeclared
2013-02-01 0:46 ` Chris Metcalf
@ 2013-02-01 0:52 ` Tejun Heo
2013-02-01 2:23 ` Chris Metcalf
0 siblings, 1 reply; 5+ messages in thread
From: Tejun Heo @ 2013-02-01 0:52 UTC (permalink / raw)
To: Chris Metcalf; +Cc: Rafael J. Wysocki, kbuild test robot, linux-kernel
Hello, Chris.
On Thu, Jan 31, 2013 at 07:46:09PM -0500, Chris Metcalf wrote:
> That seems reasonable to me, but I'm happy to experiment with
> including Kconfig.freezer from the arch/tile/Kconfig if that feels
> like a better solution.
AFAICS, there's nothing arch specific about freezer and cgroup_freezer
could be useful even without powersaving, so maybe give it a shot?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: kernel/cgroup_freezer.c:151:3: error: 'system_freezing_cnt' undeclared
2013-02-01 0:52 ` Tejun Heo
@ 2013-02-01 2:23 ` Chris Metcalf
2013-02-01 2:28 ` Tejun Heo
0 siblings, 1 reply; 5+ messages in thread
From: Chris Metcalf @ 2013-02-01 2:23 UTC (permalink / raw)
To: Tejun Heo; +Cc: Rafael J. Wysocki, kbuild test robot, linux-kernel
On 1/31/2013 7:52 PM, Tejun Heo wrote:
> Hello, Chris.
>
> On Thu, Jan 31, 2013 at 07:46:09PM -0500, Chris Metcalf wrote:
>> That seems reasonable to me, but I'm happy to experiment with
>> including Kconfig.freezer from the arch/tile/Kconfig if that feels
>> like a better solution.
> AFAICS, there's nothing arch specific about freezer and cgroup_freezer
> could be useful even without powersaving, so maybe give it a shot?
It builds with the following change. Look good to you?
commit 8c9632acfaea4cf6ae064d8291eea989b0df2bcf
Author: Chris Metcalf <cmetcalf@tilera.com>
Date: Thu Jan 31 21:21:36 2013 -0500
tile: include kernel/Kconfig.freezer in tile Kconfig
Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
diff --git a/arch/tile/Kconfig b/arch/tile/Kconfig
index 1adb853..d9072ba 100644
--- a/arch/tile/Kconfig
+++ b/arch/tile/Kconfig
@@ -142,6 +142,8 @@ config ARCH_DEFCONFIG
source "init/Kconfig"
+source "kernel/Kconfig.freezer"
+
menu "Tilera-specific configuration"
config NR_CPUS
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: kernel/cgroup_freezer.c:151:3: error: 'system_freezing_cnt' undeclared
2013-02-01 2:23 ` Chris Metcalf
@ 2013-02-01 2:28 ` Tejun Heo
0 siblings, 0 replies; 5+ messages in thread
From: Tejun Heo @ 2013-02-01 2:28 UTC (permalink / raw)
To: Chris Metcalf; +Cc: Rafael J. Wysocki, kbuild test robot, linux-kernel
On Thu, Jan 31, 2013 at 09:23:08PM -0500, Chris Metcalf wrote:
> On 1/31/2013 7:52 PM, Tejun Heo wrote:
> > Hello, Chris.
> >
> > On Thu, Jan 31, 2013 at 07:46:09PM -0500, Chris Metcalf wrote:
> >> That seems reasonable to me, but I'm happy to experiment with
> >> including Kconfig.freezer from the arch/tile/Kconfig if that feels
> >> like a better solution.
> > AFAICS, there's nothing arch specific about freezer and cgroup_freezer
> > could be useful even without powersaving, so maybe give it a shot?
>
> It builds with the following change. Look good to you?
Yeap, thanks!
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-02-01 2:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <510aa746.fVU8ZdQ2hys/RwjS%fengguang.wu@intel.com>
2013-01-31 23:14 ` kernel/cgroup_freezer.c:151:3: error: 'system_freezing_cnt' undeclared Tejun Heo
2013-02-01 0:46 ` Chris Metcalf
2013-02-01 0:52 ` Tejun Heo
2013-02-01 2:23 ` Chris Metcalf
2013-02-01 2:28 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox