From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: <rjw@sisk.pl>, <cpufreq@vger.kernel.org>,
<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linaro-dev@lists.linaro.org>, <robin.randhawa@arm.com>,
<Steve.Bannister@arm.com>, <Liviu.Dudau@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Stephen Warren <swarren@nvidia.com>,
Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH 3/3] cpufreq: Remove unnecessary use of policy->shared_type
Date: Fri, 1 Feb 2013 12:17:44 +0530 [thread overview]
Message-ID: <510B6510.6060608@ti.com> (raw)
In-Reply-To: <902bed453159832925df76e24806f3b919fdfc74.1359700706.git.viresh.kumar@linaro.org>
On Friday 01 February 2013 12:10 PM, Viresh Kumar wrote:
> policy->shared_type field was added only for SoCs with ACPI support:
>
> commit 3b2d99429e3386b6e2ac949fc72486509c8bbe36
> Author: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
> Date: Wed Dec 14 15:05:00 2005 -0500
>
> P-state software coordination for ACPI core
>
> http://bugzilla.kernel.org/show_bug.cgi?id=5737
>
> Many non-ACPI systems are filling this field by mistake, which makes its usage
> confusing. Lets clean it.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Stephen Warren <swarren@nvidia.com>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
I haven't looked at the cpufreq code recently but remember
that it was needed to ensure that all the CPU which
share clock/voltage gets updated (affected cpus) on
freq change. The CPUs which needs SW co-ordination, should
have this flag enabled and OMAP was falling in that category.
May be I miss-understood its use, but can you confirm that
SW co-ordination logic continues to work without this flag ?
Regards,
Santosh
next prev parent reply other threads:[~2013-02-01 6:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 6:40 [PATCH 1/3] cpufreq: TEGRA: Set policy->cpus from driver->init() Viresh Kumar
2013-02-01 6:40 ` [PATCH 2/3] cpufreq: Set all cpus in policy->cpus for single cluster SoCs Viresh Kumar
2013-02-01 6:41 ` Viresh Kumar
2013-02-01 6:40 ` [PATCH 3/3] cpufreq: Remove unnecessary use of policy->shared_type Viresh Kumar
2013-02-01 6:41 ` Viresh Kumar
2013-02-01 6:47 ` Santosh Shilimkar [this message]
2013-02-01 7:13 ` Viresh Kumar
2013-02-01 7:33 ` Santosh Shilimkar
2013-02-01 8:02 ` Viresh Kumar
2013-02-01 8:52 ` Santosh Shilimkar
2013-02-01 9:07 ` Santosh Shilimkar
2013-02-01 6:41 ` [PATCH 1/3] cpufreq: TEGRA: Set policy->cpus from driver->init() Viresh Kumar
2013-02-04 16:36 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510B6510.6060608@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=Liviu.Dudau@arm.com \
--cc=Steve.Bannister@arm.com \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=robin.randhawa@arm.com \
--cc=shawn.guo@linaro.org \
--cc=swarren@nvidia.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox