Re: [PATCH 3/3] cpufreq: Remove unnecessary use of policy->shared_type

Viresh Kumar
2013-02-01T07:13:15Z

On 1 February 2013 12:17, Santosh Shilimkar <santosh.shilimkar@ti.com> wrote:
> I haven't looked at the cpufreq code recently but remember
> that it was needed to ensure that all the CPU which
> share clock/voltage gets updated (affected cpus) on
> freq change. The CPUs which needs SW co-ordination, should
> have this flag enabled and OMAP was falling in that category.

Freq change are done by the target routines of platform cpufreq drivers
and they do something like:

for_each_cpu(freqs.cpu, policy->cpus)
cpufreq_notify_transition(&freqs, CPUFREQ_PRECHANGE);

The only requirement from cpufreq core is to keep cpus sharing clock
in policy->cpus.

> May be I miss-understood its use, but can you confirm that
> SW co-ordination logic continues to work without this flag ?

I believe it should work. It works for the systems i worked on:

SPEAr13xx: Dual Cortex A9
ARM TC2: two clusters of A15s and A7s.