From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757352Ab3BATDj (ORCPT ); Fri, 1 Feb 2013 14:03:39 -0500 Received: from terminus.zytor.com ([198.137.202.10]:59656 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757094Ab3BATDi (ORCPT ); Fri, 1 Feb 2013 14:03:38 -0500 Message-ID: <510C1178.1020904@zytor.com> Date: Fri, 01 Feb 2013 11:03:20 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: William Hubbs CC: linux-kernel@vger.kernel.org, mpagano@gentoo.org Subject: Re: [PATCH] init: fix name of root device in /proc/mounts References: <1359672699-23540-1-git-send-email-w.d.hubbs@gmail.com> <510AFCA1.5000700@zytor.com> <20130201171453.GA1630@linux1> In-Reply-To: <20130201171453.GA1630@linux1> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/01/2013 09:14 AM, William Hubbs wrote: > On Thu, Jan 31, 2013 at 03:22:09PM -0800, H. Peter Anvin wrote: >> On 01/31/2013 02:51 PM, William Hubbs wrote: >>> On a system that does not use an initramfs, /dev/root was always >>> listed in /proc/mounts. This breaks software which scans /proc/mounts to >>> determine which file systems are mounted since /dev/root is not a valid >>> device name. >>> >>> This changes that processing so that "/dev/root" is only added to >>> /proc/mounts if a root device is not specified with the root= option on >>> the kernel command line. >>> >>> Signed-off-by: William Hubbs >> >> Let me also point out that most of the time, the kernel actually has a >> udev device name for an actual device... > > I'm not sure what you mean. If you mean /dev/root is not an actual > device and should not be listed in /proc/mounts, that is correct and > that is why I am proposing this patch. > What I meant is that even if you *don't* specify a root= device the modern kernel will generally have a usable name. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.