From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751462Ab3BBFFI (ORCPT ); Sat, 2 Feb 2013 00:05:08 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:20406 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750743Ab3BBFFC (ORCPT ); Sat, 2 Feb 2013 00:05:02 -0500 Message-ID: <510C9E74.3070402@oracle.com> Date: Sat, 02 Feb 2013 13:04:52 +0800 From: Jeff Liu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: LKML CC: Andrew Morton Subject: [RESEND] [PATCH] kernel/res_counter.c: remove useless return statement at res_counter_member() Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The return statement after BUG() is invalid, move BUG() to the default choice of the switch. Signed-off-by: Jie Liu --- kernel/res_counter.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/res_counter.c b/kernel/res_counter.c index ff55247..748a3bc 100644 --- a/kernel/res_counter.c +++ b/kernel/res_counter.c @@ -135,10 +135,9 @@ res_counter_member(struct res_counter *counter, int member) return &counter->failcnt; case RES_SOFT_LIMIT: return &counter->soft_limit; + default: + BUG(); }; - - BUG(); - return NULL; } ssize_t res_counter_read(struct res_counter *counter, int member, -- 1.7.9.5