From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754669Ab3BDRu2 (ORCPT ); Mon, 4 Feb 2013 12:50:28 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:50218 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752420Ab3BDRu0 (ORCPT ); Mon, 4 Feb 2013 12:50:26 -0500 Message-ID: <510FF4C8.7000706@ti.com> Date: Mon, 4 Feb 2013 23:20:00 +0530 From: Sekhar Nori User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Prabhakar Lad CC: , , , , , Heiko Schocher , "Lad, Prabhakar" Subject: Re: [PATCH v2 4/6] ARM: davinci: da850: add DT node for eth0. References: <1359380879-26306-1-git-send-email-prabhakar.lad@ti.com> <1359380879-26306-5-git-send-email-prabhakar.lad@ti.com> <510E51FF.8090005@ti.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/4/2013 10:37 AM, Prabhakar Lad wrote: > Sekhar , > > On Sun, Feb 3, 2013 at 5:33 PM, Sekhar Nori wrote: >> On 1/28/2013 7:17 PM, Prabhakar Lad wrote: >>> From: Lad, Prabhakar >>> >>> Add eth0 device tree node information and pinmux for mii to da850 by >>> providing interrupt details and local mac address of eth0. >>> >>> Signed-off-by: Lad, Prabhakar >>> Cc: linux-arm-kernel@lists.infradead.org >>> Cc: linux-kernel@vger.kernel.org >>> Cc: davinci-linux-open-source@linux.davincidsp.com >>> Cc: netdev@vger.kernel.org >>> Cc: devicetree-discuss@lists.ozlabs.org >>> Cc: Sekhar Nori >>> Cc: Heiko Schocher >>> --- >>> arch/arm/boot/dts/da850-evm.dts | 5 +++++ >>> arch/arm/boot/dts/da850.dtsi | 35 +++++++++++++++++++++++++++++++++++ >>> 2 files changed, 40 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts >>> index a319491..19aa2b3 100644 >>> --- a/arch/arm/boot/dts/da850-evm.dts >>> +++ b/arch/arm/boot/dts/da850-evm.dts >>> @@ -30,6 +30,11 @@ >>> mdio: davinci_mdio@1e24000 { >>> status = "okay"; >>> }; >>> + eth0: emac@1e20000 { >>> + status = "okay"; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&mii_pins>; >>> + }; >>> }; >>> nand_cs3@62000000 { >>> status = "okay"; >>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi >>> index ba28f2d..76905f3 100644 >>> --- a/arch/arm/boot/dts/da850.dtsi >>> +++ b/arch/arm/boot/dts/da850.dtsi >>> @@ -56,6 +56,26 @@ >>> 0x30 0x01100000 0x0ff00000 >>> >; >>> }; >>> + mii_pins: pinmux_mii_pins { >>> + pinctrl-single,bits = < >>> + /* >>> + * MII_TXEN, MII_TXCLK, MII_COL >>> + * MII_TXD_3, MII_TXD_2, MII_TXD_1 >>> + * MII_TXD_0 >>> + */ >>> + 0x8 0x88888880 0xfffffff0 >>> + /* >>> + * MII_RXER, MII_CRS, MII_RXCLK >>> + * MII_RXDV, MII_RXD_3, MII_RXD_2 >>> + * MII_RXD_1, MII_RXD_0 >>> + */ >>> + 0xc 0x88888888 0xffffffff >>> + /* MDIO_CLK, MDIO_D */ >> >> You call this mii_pins, but include mdio pins in there as well. Can you >> separate them out? Then some board which uses rmii can simply reuse the >> entry. >> > Ok makes sense. > >>> + 0x10 0x00222288 0x00ffffff >>> + /* GPIO2_6 */ >>> + 0x18 0x00000080 0x000000f0 >> >> This is SoC specific pin list. Such board specific pins should not make >> it here. >> > Ok, so this should be set up using GPIO API's ? Yes, the pins ultimately will be controlled by gpiolib APIs, but the pins should be defined under the eth node in .dts Thanks, Sekhar