From: Jiri Slaby <jslaby@suse.cz>
To: James Hogan <james.hogan@imgtec.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] tty: metag_da: fix flipping after tty changes
Date: Tue, 05 Feb 2013 16:15:41 +0100 [thread overview]
Message-ID: <5111221D.1080509@suse.cz> (raw)
In-Reply-To: <1360075250-21970-1-git-send-email-james.hogan@imgtec.com>
On 02/05/2013 03:40 PM, James Hogan wrote:
> The first patch fixes up tty/metag_da after Jiri's changes, "TTY: switch
> tty_flip_buffer_push" and "TTY: convert more flipping functions",
> switched tty_flip_buffer_push() and tty_prepare_flip_string() to take
> tty_port rather than a tty_struct.
>
> The second just refactors slightly as a result of it.
>
> How is this sort of thing usually handled? I suppose either I squash it
> into the original driver and base it on tty-next, move it into tty-next,
> or just fix it up afterwards?
>
> James Hogan (2):
> tty: metag_da: update flip functions to use tty_port
> tty: metag_da: avoid getting tty kref in dashtty_timer()
They both look good. You can add my:
Acked-by: Jiri Slaby <jslaby@suse.cz>
if you want.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2013-02-05 15:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 14:40 [PATCH 0/2] tty: metag_da: fix flipping after tty changes James Hogan
2013-02-05 14:40 ` [PATCH 1/2] tty: metag_da: update flip functions to use tty_port James Hogan
2013-02-05 14:40 ` [PATCH 2/2] tty: metag_da: avoid getting tty kref in dashtty_timer() James Hogan
2013-02-05 15:15 ` Jiri Slaby [this message]
2013-02-05 15:23 ` [PATCH 0/2] tty: metag_da: fix flipping after tty changes James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5111221D.1080509@suse.cz \
--to=jslaby@suse.cz \
--cc=gregkh@linuxfoundation.org \
--cc=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox