From: James Hogan <james.hogan@imgtec.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] tty: metag_da: fix flipping after tty changes
Date: Tue, 5 Feb 2013 15:23:38 +0000 [thread overview]
Message-ID: <511123FA.6020601@imgtec.com> (raw)
In-Reply-To: <5111221D.1080509@suse.cz>
On 05/02/13 15:15, Jiri Slaby wrote:
> On 02/05/2013 03:40 PM, James Hogan wrote:
>> The first patch fixes up tty/metag_da after Jiri's changes, "TTY: switch
>> tty_flip_buffer_push" and "TTY: convert more flipping functions",
>> switched tty_flip_buffer_push() and tty_prepare_flip_string() to take
>> tty_port rather than a tty_struct.
>>
>> The second just refactors slightly as a result of it.
>>
>> How is this sort of thing usually handled? I suppose either I squash it
>> into the original driver and base it on tty-next, move it into tty-next,
>> or just fix it up afterwards?
>>
>> James Hogan (2):
>> tty: metag_da: update flip functions to use tty_port
>> tty: metag_da: avoid getting tty kref in dashtty_timer()
>
> They both look good. You can add my:
> Acked-by: Jiri Slaby <jslaby@suse.cz>
> if you want.
Thanks Jiri
Cheers
James
prev parent reply other threads:[~2013-02-05 15:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 14:40 [PATCH 0/2] tty: metag_da: fix flipping after tty changes James Hogan
2013-02-05 14:40 ` [PATCH 1/2] tty: metag_da: update flip functions to use tty_port James Hogan
2013-02-05 14:40 ` [PATCH 2/2] tty: metag_da: avoid getting tty kref in dashtty_timer() James Hogan
2013-02-05 15:15 ` [PATCH 0/2] tty: metag_da: fix flipping after tty changes Jiri Slaby
2013-02-05 15:23 ` James Hogan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511123FA.6020601@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox