From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755410Ab3BFHxs (ORCPT ); Wed, 6 Feb 2013 02:53:48 -0500 Received: from intranet.asianux.com ([58.214.24.6]:17961 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756Ab3BFHxq (ORCPT ); Wed, 6 Feb 2013 02:53:46 -0500 X-Spam-Score: -100.8 Message-ID: <51120C03.20308@asianux.com> Date: Wed, 06 Feb 2013 15:53:39 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com, acme@ghostprotocols.net CC: "linux-kernel@vger.kernel.org" Subject: [PATCH] kernel/events: using uninitialized variable: slots.flexible for arm cross-compiling Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org for arm cross-compiling, in function __reserve_bp_slot: slots.flexible may be used without initializing. slots.flexible is not initialized when define it. it is as a parameter passed to fetch_bp_busy_slots. in function fetch_bp_busy_slots: if bp->cpu < 0 slots->flexible will be used for comparing, firstly. that will cause issue. building: make EXTRA_CFLAGS=-W ARCH=arm ... linux/kernel/events/hw_breakpoint.c:300: warning: missing initializer linux/kernel/events/hw_breakpoint.c:300: warning: (near initialization for 'slots.flexible') ... Signed-off-by: Chen Gang --- kernel/events/hw_breakpoint.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c index fe8a916..ef69215 100644 --- a/kernel/events/hw_breakpoint.c +++ b/kernel/events/hw_breakpoint.c @@ -297,7 +297,7 @@ __weak void arch_unregister_hw_breakpoint(struct perf_event *bp) */ static int __reserve_bp_slot(struct perf_event *bp) { - struct bp_busy_slots slots = {0}; + struct bp_busy_slots slots = {0, 0}; enum bp_type_idx type; int weight; -- 1.7.7.6