[PATCH] kernel/events: using uninitialized variable: slots.flexible for arm cross-compiling

[PATCH] kernel/events: using uninitialized variable: slots.flexible for arm cross-compiling

[Chen Gang]

for arm cross-compiling, in function __reserve_bp_slot:

  slots.flexible may be used without initializing.

    slots.flexible is not initialized when define it.
    it is as a parameter passed to fetch_bp_busy_slots.
    in function fetch_bp_busy_slots:
      if bp->cpu < 0
        slots->flexible will be used for comparing, firstly.
        that will cause issue.


building:
  make EXTRA_CFLAGS=-W ARCH=arm
  ...
  linux/kernel/events/hw_breakpoint.c:300:
    warning: missing initializer
  linux/kernel/events/hw_breakpoint.c:300:
    warning: (near initialization for 'slots.flexible')
  ...

Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
 kernel/events/hw_breakpoint.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c
index fe8a916..ef69215 100644
--- a/kernel/events/hw_breakpoint.c
+++ b/kernel/events/hw_breakpoint.c
@@ -297,7 +297,7 @@ __weak void arch_unregister_hw_breakpoint(struct perf_event *bp)
  */
 static int __reserve_bp_slot(struct perf_event *bp)
 {
-	struct bp_busy_slots slots = {0};
+	struct bp_busy_slots slots = {0, 0};
 	enum bp_type_idx type;
 	int weight;
 
-- 
1.7.7.6

Re: [PATCH] kernel/events: using uninitialized variable: slots.flexible for arm cross-compiling

[Chen Gang]

  oh, sorry, it is my fault, please skip this patch.

gchen.

于 2013年02月06日 15:53, Chen Gang 写道:
> 
> for arm cross-compiling, in function __reserve_bp_slot:
> 
>   slots.flexible may be used without initializing.
> 
>     slots.flexible is not initialized when define it.
>     it is as a parameter passed to fetch_bp_busy_slots.
>     in function fetch_bp_busy_slots:
>       if bp->cpu < 0
>         slots->flexible will be used for comparing, firstly.
>         that will cause issue.
> 
> 
> building:
>   make EXTRA_CFLAGS=-W ARCH=arm
>   ...
>   linux/kernel/events/hw_breakpoint.c:300:
>     warning: missing initializer
>   linux/kernel/events/hw_breakpoint.c:300:
>     warning: (near initialization for 'slots.flexible')
>   ...
> 
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
>  kernel/events/hw_breakpoint.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c
> index fe8a916..ef69215 100644
> --- a/kernel/events/hw_breakpoint.c
> +++ b/kernel/events/hw_breakpoint.c
> @@ -297,7 +297,7 @@ __weak void arch_unregister_hw_breakpoint(struct perf_event *bp)
>   */
>  static int __reserve_bp_slot(struct perf_event *bp)
>  {
> -	struct bp_busy_slots slots = {0};
> +	struct bp_busy_slots slots = {0, 0};
>  	enum bp_type_idx type;
>  	int weight;
>  
> 


-- 
Chen Gang

Asianux Corporation