From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757603Ab3BGBSG (ORCPT ); Wed, 6 Feb 2013 20:18:06 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:32890 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754804Ab3BGBSD (ORCPT ); Wed, 6 Feb 2013 20:18:03 -0500 Message-ID: <51130088.4010706@oracle.com> Date: Wed, 06 Feb 2013 20:16:56 -0500 From: Sasha Levin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130113 Thunderbird/17.0.2 MIME-Version: 1.0 To: Andrew Morton CC: Michel Lespinasse , Andrea Arcangeli , Rik van Riel , Mel Gorman , Hugh Dickins , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mm: use long type for page counts in mm_populate() and get_user_pages() References: <1359591980-29542-1-git-send-email-walken@google.com> <1359591980-29542-2-git-send-email-walken@google.com> <5112F7AF.6010307@oracle.com> <20130206171047.d27b5772.akpm@linux-foundation.org> In-Reply-To: <20130206171047.d27b5772.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/06/2013 08:10 PM, Andrew Morton wrote: > On Wed, 06 Feb 2013 19:39:11 -0500 > Sasha Levin wrote: > >> We're now hitting the VM_BUG_ON() which was added in the last hunk of the >> patch: > > hm, why was that added. > > Michel, I seem to have confused myself over this series. I saw a > report this morning which led me to drop > mm-accelerate-munlock-treatment-of-thp-pages.patch but now I can't find > that report and I'm wondering if I should have dropped > mm-accelerate-mm_populate-treatment-of-thp-pages.patch instead. > > Given that and Sasha's new report I think I'll drop > > mm-use-long-type-for-page-counts-in-mm_populate-and-get_user_pages.patch > mm-use-long-type-for-page-counts-in-mm_populate-and-get_user_pages-fix.patch > mm-use-long-type-for-page-counts-in-mm_populate-and-get_user_pages-fix-fix.patch > mm-accelerate-mm_populate-treatment-of-thp-pages.patch > mm-accelerate-munlock-treatment-of-thp-pages.patch > > and let's start again? I've sent a report regarding mm-accelerate-munlock-treatment-of-thp-pages.patch couple of hours ago (https://lkml.org/lkml/2013/2/6/699). Reverting that patch fixed the issue reported, so I think you've dropped the right one. Thanks, Sasha